fix(voice): keep trace active until pipeline processing completes#2472
Open
OiPunk wants to merge 1 commit intoopenai:mainfrom
Open
fix(voice): keep trace active until pipeline processing completes#2472OiPunk wants to merge 1 commit intoopenai:mainfrom
OiPunk wants to merge 1 commit intoopenai:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TraceCtxManagerscope into the background tasks for both single-turn and multi-turn voice pipeline execution so the trace stays open for the full async lifecyclesession_ended; wait for graceful producer completion first sotrace_endcan be emitted reliablyon_start()intro/exception path continuing without aborting the sessionRoot Cause
VoicePipelinepreviously enteredTraceCtxManageronly around task creation, then returned immediately. This ended the trace before async processing finished, causing subsequent spans to be emitted after trace closure.Testing
uv run ruff check src/agents/voice/pipeline.py src/agents/voice/result.py tests/voice/test_pipeline.pyenv -u ALL_PROXY -u all_proxy -u HTTPS_PROXY -u https_proxy -u HTTP_PROXY -u http_proxy -u NO_PROXY -u no_proxy uv run --extra voice pytest tests/voice/test_pipeline.py -qenv -u ALL_PROXY -u all_proxy -u HTTPS_PROXY -u https_proxy -u HTTP_PROXY -u http_proxy -u NO_PROXY -u no_proxy uv run --extra voice coverage run -m pytest tests/voice/test_pipeline.py -qsrc/agents/voice/pipeline.pyandsrc/agents/voice/result.pyare both 100%Fixes #2470