Update responsive-tabs.js#43
Open
mav2287 wants to merge 4 commits intoopenam:masterfrom
mav2287:patch-1
Open
Conversation
By making the following changes you allow the actual tabs themselves to be above(before) or below(after) the panel content. Without this change if the code has the order of <div id="tabcontentbelow" class="tab-content responsive"><ul id="tabnavbelow" class="nav nav-tabs responsive"> instead of the more common <ul id="tabnavbelow" class="nav nav-tabs responsive"><div id="tabcontentbelow" class="tab-content responsive"> the script will not work. The reason for this is two .next usages that are based on the assumption that it will be written in that order. The correction goes based off the classes and still works with multiple tabs on 1 page. This allows for tabs above, below, left, and right.
The changes here will account for using panels inside a tab. Otherwise if the screen is resized the panel will get treated as though it was one of the panels for the tab
Author
|
This should now account for tabs out of order and tabs with panels in them. Without this out of order panels won't work and panels in a tab will get messed up when switching back to normal mode. |
Author
|
Sorry about doing so many commits stupid copy paste didn't work right. The last commit has the patch for allowing for panels within tab content as well as the fix for the tabs below content |
Owner
There was a problem hiding this comment.
Will you remove this extra line break.
Owner
|
Please squash all the commits together, and then rebase. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By making the following changes you allow the actual tabs themselves to be above(before) or below(after) the panel content. Without this change if the code has the order of
instead of the more common the script will not work. The reason for this is two .next usages that are based on the assumption that it will be written in that order. The correction goes based off the classes and still works with multiple tabs on 1 page. This allows for tabs above, below, left, and right.