Skip to content

Update gsl-lite to 1.0.1#4

Open
musicinmybrain wants to merge 1 commit intoopenbraininstitute:masterfrom
musicinmybrain:gsl-lite-1
Open

Update gsl-lite to 1.0.1#4
musicinmybrain wants to merge 1 commit intoopenbraininstitute:masterfrom
musicinmybrain:gsl-lite-1

Conversation

@musicinmybrain
Copy link
Contributor

See https://github.com/gsl-lite/gsl-lite/releases/tag/v1.0.0 and https://gsl-lite.github.io/gsl-lite/#migration-guide.

In gsl-lite 1.x, gsl_CONFIG_ALLOWS_SPAN_COMPARISON defaults to 0, so I implemented it manually for morphio::range.

See https://github.com/gsl-lite/gsl-lite/releases/tag/v1.0.0 and
https://gsl-lite.github.io/gsl-lite/#migration-guide.

In gsl-lite 1.x, `gsl_CONFIG_ALLOWS_SPAN_COMPARISON` defaults to 0, so I
implemented it manually for `morphio::range`.
@sanjayankur31
Copy link
Contributor

Hello---any updates here please? (If it isn't an issue, the gsl git submodule should also be updated to v1.x---v0.4 is 5 years old..)

@mgeplf
Copy link
Collaborator

mgeplf commented Mar 11, 2026

Hello---any updates here please?

Sorry, I haven't had much time for maintenance on this repo; I will see if I can find time.

@sanjayankur31
Copy link
Contributor

thanks @mgeplf , no hurry as always

mgeplf added a commit that referenced this pull request Mar 11, 2026
@mgeplf mgeplf mentioned this pull request Mar 11, 2026
@mgeplf
Copy link
Collaborator

mgeplf commented Mar 12, 2026

@sanjayankur31 > no hurry as always

I looked at this a bit yesterday, and it seems that upstream has changed how they have laid out their CMake files.

I'm considering "just" versioning in the gsl-lite requirement, but I don't know what the impact on packaging would be in that case. Do you have any guidance @sanjayankur31?

@sanjayankur31
Copy link
Contributor

Do you mean pinning it to a particular version? In that case, if this version is not what the Fedora package of gsl-lite is at, we'll need to bundle that in when we build morphio, but that's fine for us to do.

It will likely mean that morphio will remain pinned on an older version of gsl-lite, since no one will be testing it with newer versions. We can try it out with the gsl-lite package from time to time downstream and provide feedback. For this ticket, I guess if morphio is pinned to gsl-lite v1.x now, that should work for a long time (assuming that gsl-lite follows semver and remains API compatible throughout the v1 series).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants