WIP - Documentation api, addressing warnings#220
Open
AlbertoCasasOrtiz wants to merge 14 commits intodevfrom
Open
WIP - Documentation api, addressing warnings#220AlbertoCasasOrtiz wants to merge 14 commits intodevfrom
AlbertoCasasOrtiz wants to merge 14 commits intodevfrom
Conversation
Member
Author
AlbertoCasasOrtiz
left a comment
AlbertoCasasOrtiz
left a comment
There was a problem hiding this comment.
I have just fixed conflicts and reviewed this PR and everything looks good. The only thing is that the pycharm formatter did some silly things, but i will fix that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@carmichaelong This PR is bigger than I expected, so I will take some time to check everything is correct. I basically reformatted everything to remove warnings and errors, and added swagger documentation and docstrings to views.py.
It will probably collide with dev, or any changes we have pending, so we should address this PR with caution.