Mono integration - model files without neutral trial#281
Open
Mono integration - model files without neutral trial#281
Conversation
Collaborator
|
thanks. can you make the PR into dev, we review there, test on dev, then go dev -> main |
Contributor
Author
|
Done, changed to 'dev' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we have no neutral trial, our models are not at the same place in the database.
I modified a little bit the logic behind the 'download data'. When the session if a monocular one, it calls
collect_opensim_model_files(trial, isMono=True)for each trial and it adds them in the zip to the pathOpenSimData/Model/<trial.formated_name>/<modelName.osim>.There were a few ways to code this but I think this one is clean.