[WIP] Ignore camera confidence when syncing with hand raise#180
Open
parkersruth wants to merge 1 commit intoopencap-org:mainfrom
Open
[WIP] Ignore camera confidence when syncing with hand raise#180parkersruth wants to merge 1 commit intoopencap-org:mainfrom
parkersruth wants to merge 1 commit intoopencap-org:mainfrom
Conversation
Collaborator
|
This ought to work. We want to avoid spurious low confidence shoulder and hand positions. This and the following line filter out low confidence and smooth, which should be enough, but we should do some testing. Can you test reprocess a few walking and maybe TUG sessions (there will be some low-confidence arms during the turn). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I believe commenting out this line should allow hand punch synchronization to be performed without eliminating low-confidence keypoints.