Fix namespace extraction from qualified domain ref #200
+38
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
useComponentEntityDetails now parses the qualified spec.domain ref (e.g. "default/team-alpha") using parseEntityRef to extract just the domain name, instead of passing the full ref as the namespace name to OpenChoreo API calls. useWorkflowData no longer sets error state when fetchComponentDetails fails, allowing the Workflows page to fall through to the "Workflows Not Available" empty state instead of showing a raw HTTP error Signed-off-by: Kavith Lokuhewage <kaviththiranga@gmail.com>
kaviththiranga
requested review from
jhivandb and
sameerajayasoma
as code owners
LakshanSS
approved these changes
Jan 28, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
useComponentEntityDetails now parses the qualified spec.domain ref
(e.g. "default/team-alpha") using parseEntityRef to extract just the
domain name, instead of passing the full ref as the namespace name to
OpenChoreo API calls.
useWorkflowData no longer sets error state when fetchComponentDetails
fails, allowing the Workflows page to fall through to the "Workflows
Not Available" empty state instead of showing a raw HTTP error