Skip to content

discard cue when start / end times are invalid #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alexis779 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

discard cue when start / end times are invalid #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lib/parser.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,8 @@ def parse
@start = Timestamp.new $1
@end = Timestamp.new $2
@style = Hash[$3.strip.split(" ").map{|s| s.split(":").map(&:strip) }]
else
return
end
@text = lines[1..-1].join("\n")
end
Expand Down
6 changes: 6 additions & 0 deletions tests/parser.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,4 +210,10 @@ def test_invalid_cue
webvtt = WebVTT.convert_from_srt("tests/subtitles/invalid_cue.srt")
assert_equal 1, webvtt.cues.size
end

def test_invalid_cue_time
cue_string = open("tests/subtitles/invalid_cue_time.srt").read
cue = WebVTT::Cue.parse(cue_string)
assert_nil cue.text
end
end
3 changes: 3 additions & 0 deletions tests/subtitles/invalid_cue_time.srt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
9999
00:00:0,500 --> 00:00:2,00
<font color="#ffff00" size=14>www.tvsubtitles.net</font>