[Regression fix] Fix enum sequencing issue #2243
Merged
+26
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tejaswini Chadaga <tchadaga@microsoft.com>
tjchadaga
force-pushed
the
meta_enum_fix_master
branch
from
33adb5d to
23783c7
Compare
Collaborator
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
Author
|
JaiOCP
reviewed
Jan 15, 2026
Contributor
JaiOCP
left a comment
JaiOCP
left a comment
There was a problem hiding this comment.
How did the commit check passed. Usually they complain.
Is there a tooling issue that need to addressed?
Collaborator
|
Metadata headers are excluded from enum compatibility check since some headers are auto generated and metadatatypes could contain vales for experimental values which can potentially disappear, saimetadatatypes.h could be added explicitly for validation chęć but since backward compatibility was broken already then broken commits would need to be explicitly handled in validator to not break compatibility or star compatibility from this commit Here: Line 130 in 77578c8 |
JaiOCP
approved these changes
Jan 15, 2026
rck-innovium
approved these changes
Jan 15, 2026
tjchadaga
added a commit
that referenced
this pull request
Jan 15, 2026
Signed-off-by: Tejaswini Chadaga <tchadaga@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The below PRs introduced changes in saimetadatatypes.h which broke backward compatibility
This PR is to change the newly introduced enum values, so the existing enum values are not changed