Skip to content

Simulation Experiment view: account for a SED-ML task instance having issues#435

Merged
agarny merged 3 commits intoopencor:mainfrom
agarny:issue432
Mar 1, 2026
Merged

Simulation Experiment view: account for a SED-ML task instance having issues#435
agarny merged 3 commits intoopencor:mainfrom
agarny:issue432

Conversation

@agarny
Copy link
Contributor

@agarny agarny commented Mar 1, 2026

No description provided.

Copilot AI review requested due to automatic review settings March 1, 2026 09:05
@agarny agarny changed the title Simulation Experiment: account for a SED-ML instance having issues Simulation Experiment view: account for a SED-ML instance having issues Mar 1, 2026
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Simulation Experiment view to better handle cases where a SED-ML document instantiation reports issues, and bumps renderer/root versions alongside dependency lockfile updates.

Changes:

  • Show an IssuesView when the instantiated SED-ML instance reports issues, and attempt to avoid accessing task-derived fields in that case.
  • Update the renderer dependency update script to remove bun.lock before reinstalling.
  • Bump package versions and refresh Bun lockfiles.

Reviewed changes

Copilot reviewed 4 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/renderer/src/components/views/SimulationExperimentView.vue Adds a top-level issues display and adds guards intended to avoid using invalid instance/task data.
src/renderer/scripts/dependencies.update.js Removes bun.lock after bun update to force regeneration on install.
src/renderer/package.json Version bump.
src/renderer/bun.lock Dependency lock updates.
package.json Version bump.
bun.lock Dependency lock updates.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@agarny agarny changed the title Simulation Experiment view: account for a SED-ML instance having issues Simulation Experiment view: account for a SED-ML task instance having issues Mar 1, 2026
@agarny agarny force-pushed the issue432 branch 2 times, most recently from 20a6fe3 to 56c40f0 Compare March 1, 2026 20:46
@agarny agarny requested a review from Copilot March 1, 2026 20:46
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 6 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 6 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@agarny agarny merged commit 8f7b25d into opencor:main Mar 1, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants