Open
Conversation
Codecov Report
@@ Coverage Diff @@
## main #16 +/- ##
==========================================
+ Coverage 97.19% 97.35% +0.15%
==========================================
Files 33 37 +4
Lines 1607 1665 +58
==========================================
+ Hits 1562 1621 +59
+ Misses 45 44 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
PaParaZz1
requested changes
Feb 21, 2023
| from .shape import __all__ as _shape_all | ||
|
|
||
| __all__ = [ | ||
| *_shape_all |
Member
There was a problem hiding this comment.
add comments, such as some functions examples
| if constraint: | ||
| return constraint.prefix | ||
| else: | ||
| return None |
Member
There was a problem hiding this comment.
maybe we should raise RuntimeError here
| assert not c1 > shape_prefix(2, 3, 3) | ||
| assert not c1 < shape_prefix(2, 3, 3) | ||
|
|
||
| assert not c1 >= np.ndarray |
Member
There was a problem hiding this comment.
why add this comparison, maybe we should add some explanation comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.