Skip to content

fix: correct update subs plan URL and payload and unittest #976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iloveagent57 merged 1 commit into from
Dec 5, 2025
Merged

fix: correct update subs plan URL and payload and unittest #976

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions enterprise_access/apps/api_client/license_manager_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@


NEW_SUBSCRIPTION_CHANGE_REASON = 'new'
OTHER_SUBSCRIPTION_CHANGE_REASON = 'other'


class LicenseManagerApiClient(BaseOAuthClient):
Expand Down Expand Up @@ -226,9 +227,10 @@ def update_subscription_plan(self, subscription_uuid, salesforce_opportunity_lin
Raises:
APIClientException: If the API call fails
"""
endpoint = f"{self.subscriptions_endpoint}{subscription_uuid}/"
endpoint = f"{self.subscription_provisioning_endpoint}{subscription_uuid}/"
payload = {
'salesforce_opportunity_line_item': salesforce_opportunity_line_item
'salesforce_opportunity_line_item': salesforce_opportunity_line_item,
'change_reason': OTHER_SUBSCRIPTION_CHANGE_REASON,
}

try:
Expand Down
28 changes: 28 additions & 0 deletions enterprise_access/apps/api_client/tests/test_license_manager_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
from enterprise_access.apps.api_client.exceptions import APIClientException
from enterprise_access.apps.api_client.license_manager_client import (
NEW_SUBSCRIPTION_CHANGE_REASON,
OTHER_SUBSCRIPTION_CHANGE_REASON,
LicenseManagerApiClient,
LicenseManagerUserApiClient
)
Expand Down Expand Up @@ -133,6 +134,33 @@ def test_create_subscription_plan(self, mock_oauth_client):
json=expected_payload,
)

@mock.patch('enterprise_access.apps.api_client.base_oauth.OAuthAPIClient', autospec=True)
def test_update_subscription_plan(self, mock_oauth_client):
mock_patch = mock_oauth_client.return_value.patch
subs_plan_uuid = uuid.uuid4()
new_oli_value = '1234512345'

lm_client = LicenseManagerApiClient()

result = lm_client.update_subscription_plan(
subs_plan_uuid, new_oli_value,
)

self.assertEqual(result, mock_patch.return_value.json.return_value)
expected_url = (
'http://license-manager.example.com'
f'/api/v1/provisioning-admins/subscriptions/{subs_plan_uuid}/'
)
expected_payload = {
'salesforce_opportunity_line_item': new_oli_value,
'change_reason': OTHER_SUBSCRIPTION_CHANGE_REASON,
}
mock_patch.assert_called_once_with(
expected_url,
json=expected_payload,
timeout=settings.LICENSE_MANAGER_CLIENT_TIMEOUT,
)


class TestLicenseManagerUserApiClient(MockLicenseManagerMetadataMixin):
"""
Expand Down