feat: reorder components in unit page [FC-00083]#1816
feat: reorder components in unit page [FC-00083]#1816ChrisChV merged 11 commits intoopenedx:masterfrom
Conversation
|
Thanks for the pull request, @navinkarkera! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1816 +/- ##
==========================================
+ Coverage 93.58% 93.63% +0.04%
==========================================
Files 1141 1141
Lines 23321 23368 +47
Branches 5015 5025 +10
==========================================
+ Hits 21826 21881 +55
+ Misses 1427 1411 -16
- Partials 68 76 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
6a0745d to
277bcbb
Compare
pomegranited
left a comment
There was a problem hiding this comment.
👍 This looks and works beautifully. Great work @navinkarkera !
- I tested this on my tutor dev stack using the PR test instructions.
- I read through the code
- I checked for accessibility issues by using my keyboard to navigate -- so nice!
- Includes documentation -- code and test comments
- User-facing strings are extracted for translation
| activeId={hidePreviewFor} | ||
| setActiveId={setHidePreviewFor} |
605c3af to
9aa3605
Compare
9aa3605 to
11bc01a
Compare
Description
Reorders components in unit page via drag and drop. This PR also refactors and moves draggable list and sortable item components to appropriate location.
Course authors will be affected by this change.
Supporting information
Related to: #1621
Private-ref: FAL-4060Testing instructions
Other information
Include anything else that will help reviewers and consumers understand the change.