Skip to content

feat: reorder components in unit page [FC-00083]#1816

Merged
ChrisChV merged 11 commits intoopenedx:masterfrom
open-craft:navin/fal-4060/reorder-components
Apr 16, 2025
Merged

feat: reorder components in unit page [FC-00083]#1816
ChrisChV merged 11 commits intoopenedx:masterfrom
open-craft:navin/fal-4060/reorder-components

Conversation

@navinkarkera
Copy link
Contributor

Description

Reorders components in unit page via drag and drop. This PR also refactors and moves draggable list and sortable item components to appropriate location.

Course authors will be affected by this change.

Supporting information

Related to: #1621
Private-ref: FAL-4060

Testing instructions

Other information

Include anything else that will help reviewers and consumers understand the change.

  • Does this change depend on other changes elsewhere?
  • Any special concerns or limitations? For example: deprecations, migrations, security, or accessibility.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Apr 14, 2025
@openedx-webhooks
Copy link

openedx-webhooks commented Apr 14, 2025

Thanks for the pull request, @navinkarkera!

This repository is currently maintained by @openedx/2u-tnl.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@codecov
Copy link

codecov bot commented Apr 14, 2025

Codecov Report

Attention: Patch coverage is 94.33962% with 3 lines in your changes missing coverage. Please review.

Project coverage is 93.63%. Comparing base (4bd2c3b) to head (11bc01a).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/library-authoring/units/LibraryUnitBlocks.tsx 92.85% 2 Missing ⚠️
src/generic/DraggableList/DraggableList.jsx 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1816      +/-   ##
==========================================
+ Coverage   93.58%   93.63%   +0.04%     
==========================================
  Files        1141     1141              
  Lines       23321    23368      +47     
  Branches     5015     5025      +10     
==========================================
+ Hits        21826    21881      +55     
+ Misses       1427     1411      -16     
- Partials       68       76       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mphilbrick211 mphilbrick211 moved this from Needs Triage to Waiting on Author in Contributions Apr 14, 2025
@mphilbrick211 mphilbrick211 added the FC Relates to an Axim Funded Contribution project label Apr 14, 2025
@navinkarkera navinkarkera force-pushed the navin/fal-4060/reorder-components branch from 6a0745d to 277bcbb Compare April 15, 2025 07:20
@navinkarkera navinkarkera marked this pull request as ready for review April 15, 2025 11:00
@navinkarkera navinkarkera changed the title feat: reorder components in unit page feat: reorder components in unit page [FC-00083] Apr 15, 2025
Copy link
Contributor

@pomegranited pomegranited left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 This looks and works beautifully. Great work @navinkarkera !

  • I tested this on my tutor dev stack using the PR test instructions.
  • I read through the code
  • I checked for accessibility issues by using my keyboard to navigate -- so nice!
  • Includes documentation -- code and test comments
  • User-facing strings are extracted for translation

Comment on lines +188 to +209
activeId={hidePreviewFor}
setActiveId={setHidePreviewFor}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really nice.

@navinkarkera navinkarkera force-pushed the navin/fal-4060/reorder-components branch from 605c3af to 9aa3605 Compare April 16, 2025 11:43
@navinkarkera navinkarkera force-pushed the navin/fal-4060/reorder-components branch from 9aa3605 to 11bc01a Compare April 16, 2025 11:50
@ChrisChV ChrisChV merged commit 3b2adc2 into openedx:master Apr 16, 2025
7 checks passed
@ChrisChV ChrisChV deleted the navin/fal-4060/reorder-components branch April 16, 2025 19:34
@github-project-automation github-project-automation bot moved this from Waiting on Author to Done in Contributions Apr 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

FC Relates to an Axim Funded Contribution project open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants