feat: fixes after package-lock regen #1837

filippovskii09 · 2025-12-04T14:21:40Z

Description

This PR solved several issues that arose after deleting the node_modules folder, the package-lock.json file and running the npm install command for install dependencies.

List of problomes

Jest reporter issue jest-console-group-reporter.
Sass build warnings.
Paragon modal issues in tests.
frontend-lib-special-exams test failures.

How to test it

Run this command rm -rf node_modules package-lock.json
Run this command npm install or npm i
Re-run your local container
And run these commands npm run test, npm run build, npm run types, npm run lint
And test UI

openedx-webhooks · 2025-12-04T14:21:46Z

Thanks for the pull request, @filippovskii09!

This repository is currently maintained by @openedx/committers-frontend-app-learning.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
- This process (including the steps you'll need to take) is documented here.
If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

Dependencies

This PR must be merged before / after / at the same time as ...
Blockers

This PR is waiting for OEP-1234 to be accepted.
Timeline information

This PR must be merged by XX date because ...
Partner information

This is for a course on edx.org.
Supporting documentation
Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Update the status of your PR

Your PR is currently marked as a draft. After completing the steps above, update its status by clicking "Ready for Review", or removing "WIP" from the title, as appropriate.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

The size and impact of the changes that it introduces
The need for product review
Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

codecov · 2025-12-05T09:26:08Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.56%. Comparing base (630e843) to head (d092057).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1837      +/-   ##
==========================================
+ Coverage   91.18%   91.56%   +0.38%     
==========================================
  Files         349      349              
  Lines        5831     5835       +4     
  Branches     1376     1382       +6     
==========================================
+ Hits         5317     5343      +26     
+ Misses        497      473      -24     
- Partials       17       19       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

PKulkoRaccoonGang · 2025-12-10T09:48:15Z

src/courseware/course/sequence/Unit/ContentIFrame.test.jsx

+  const actual = jest.requireActual('@openedx/paragon');
+  const PropTypes = jest.requireActual('prop-types');
+
+  const MockModalDialog = ({ children, isOpen, onClose }) => {


[important]: Is it possible to abandon the mock of this Paragon component?

this mock resolve third issue about Paragon modal issues in tests in this ticket

Yes, this mock simulates the behavior of a modal window with data-testid="modal-backdrop". However, is it now clear why we’re getting the error TestingLibraryElementError: Unable to find an element by: [data-testid="modal-backdrop"]?

PKulkoRaccoonGang · 2025-12-10T09:51:14Z

src/courseware/data/pact-tests/lmsPact.test.jsx

+    // Mock Intl.DateTimeFormat to return a consistent timezone across all environments
+    // This ensures that the browser_timezone query parameter matches the pact file
+    const OriginalDateTimeFormat = Intl.DateTimeFormat;
+    jest.spyOn(Intl, 'DateTimeFormat').mockImplementation((...args) => {


[question]: What exactly caused this change? Why did the tests work without it before?

it was removed

…ning into filippovskii/fix/deps-after-lock-regen

PKulkoRaccoonGang · 2026-01-08T09:06:47Z

...se/new-sidebar/sidebars/discussions-notifications/notifications/NotificationsWidget.test.tsx


  beforeEach(async () => {
-    global.innerWidth = breakpoints.large.minWidth;
+    global.innerWidth = breakpoints.large.minWidth ?? 992;


It would be nice for all breakpoints we use as fallbacks to have constant variables, instead of hardcoded values.

Oh wait, I just remembered that Paragon already exports a breakpoints object, so let's use that instead new constants

used breakpoints from Paragon

PKulkoRaccoonGang · 2026-01-08T09:08:18Z

webpack.dev.config.js

+});
+
+// Fix for sass-loader deprecation warnings
+config.module.rules.forEach((rule) => {


Can we do without this? I think there is nothing wrong with displaying warnings.

PKulkoRaccoonGang · 2026-01-08T09:09:19Z

jest.config.js


 // delete config.testURL;

-config.reporters = [...(config.reporters || []), ["jest-console-group-reporter", {


Could you add some context as to why we are removing this?

After regenerating package-lock.json, the dependency updates caused the jest-console-group-reporter to fail with a TypeError: Cannot read properties of undefined (reading 'isSet') during the test run.
Since this is just a reporter utility for grouping console logs and its failure was blocking the test suite execution, I removed it to restore stability to the CI pipeline.

open-craft-grove · 2026-01-08T10:29:30Z

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

open-craft-grove · 2026-01-08T12:54:41Z

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

open-craft-grove · 2026-01-08T13:38:09Z

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

open-craft-grove · 2026-01-15T12:26:30Z

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

open-craft-grove · 2026-01-20T07:08:19Z

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

open-craft-grove · 2026-01-20T18:56:45Z

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

itsjeyd · 2026-01-26T09:54:04Z

Hi @filippovskii09, thank you for this contribution!

Since it seems to include changes to user-facing functionality, it will need product approval before it can be merged.

So if this PR doesn't belong to https:/d/github.com/openedx/platform-roadmap/issues/495 (?), please choose your product contribution type and follow the corresponding instructions to get the product review process started.

CC @PKulkoRaccoonGang

openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Dec 4, 2025

openedx-webhooks added this to Contributions Dec 4, 2025

github-project-automation bot moved this to Needs Triage in Contributions Dec 4, 2025

filippovskii09 force-pushed the filippovskii/fix/deps-after-lock-regen branch from 46f8906 to d6961e9 Compare December 4, 2025 15:31

filippovskii09 self-assigned this Dec 5, 2025

fix: resolve TypeScript and test issues after dependency update

5acf4e4

filippovskii09 force-pushed the filippovskii/fix/deps-after-lock-regen branch from b48ac34 to 5acf4e4 Compare December 5, 2025 15:00

filippovskii09 added 2 commits December 5, 2025 17:15

chore: retrigger CI

6910a68

fix: some fixes

c3e5cc3

PKulkoRaccoonGang suggested changes Dec 10, 2025

View reviewed changes

fix: remove extra mock and regenerate package-lock

b350aa4

itsjeyd added the product review PR requires product review before merging label Dec 11, 2025

itsjeyd moved this from Needs Triage to Waiting on Author in Contributions Dec 11, 2025

filippovskii09 added 3 commits December 11, 2025 13:43

fix: fix test coverage

a72e98a

fix: update package-lock

aec768f

fix: resolve errors with tests

1403bc7

filippovskii09 requested a review from PKulkoRaccoonGang December 11, 2025 14:39

Merge branch 'master' of https://github.com/openedx/frontend-app-lear…

3443718

…ning into filippovskii/fix/deps-after-lock-regen

PKulkoRaccoonGang suggested changes Jan 8, 2026

View reviewed changes

PKulkoRaccoonGang added the create-sandbox open-craft-grove should create a sandbox environment from this PR label Jan 8, 2026

filippovskii09 added 3 commits January 8, 2026 14:12

fix: add constants for breakpoints

b8ccb3b

fix: remove some config setup from wbdc.js

ed3a8d7

fix: remove extra imports

2faaf77

filippovskii09 requested a review from PKulkoRaccoonGang January 8, 2026 15:15

fix: using breakpoints from paragon

d092057


		// delete config.testURL;

		config.reporters = [...(config.reporters \|\| []), ["jest-console-group-reporter", {

feat: fixes after package-lock regen #1837

Are you sure you want to change the base?

feat: fixes after package-lock regen #1837

Uh oh!

Conversation

filippovskii09 commented Dec 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

openedx-webhooks commented Dec 4, 2025

Uh oh!

codecov bot commented Dec 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

open-craft-grove commented Jan 8, 2026

Uh oh!

open-craft-grove commented Jan 8, 2026

Uh oh!

open-craft-grove commented Jan 8, 2026

Uh oh!

open-craft-grove commented Jan 15, 2026

Uh oh!

open-craft-grove commented Jan 20, 2026

Uh oh!

open-craft-grove commented Jan 20, 2026

Uh oh!

itsjeyd commented Jan 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

filippovskii09 commented Dec 4, 2025 •

edited

Loading

codecov bot commented Dec 5, 2025 •

edited

Loading