docs: Update migration howto with jest @src alias#182
Open
arbrandes wants to merge 1 commit intoopenedx:mainfrom
Open
docs: Update migration howto with jest @src alias#182arbrandes wants to merge 1 commit intoopenedx:mainfrom
arbrandes wants to merge 1 commit intoopenedx:mainfrom
Conversation
arbrandes
force-pushed
the
update-migration-howto
branch
from
bc1fbb7 to
8273152
Compare
The migration howto was missing the @src alias in jest configuration, since it's no longer provided by the default in frontend-base. Add the finding that `tsc-alias` needs to be called after assets are copied. Finally, document the fix to the site.config.test.tsx circular dependency when mocking `@openedx/frontend-base` itself.
arbrandes
force-pushed
the
update-migration-howto
branch
from
8273152 to
7205845
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The migration howto was missing the @src alias in jest configuration, since it's no longer provided by the default in frontend-base.
The
site.config.test.tsxcircular import fix was also included.