Fix Enum ARRAY-mapping for extended classes.#164
Merged
Conversation
…tributes, because they are stored according to the iliname - and an attribute of the base class that is used in a table of an extended class has still the iliname of the base class - thats why it now checks its real iliname instead of concatinating it from the tables iliname.
gacarrillor
approved these changes
Feb 2, 2026
Member
|
@signedav, is there something critical with the test failures? |
Member
Author
|
I think I have to fix it. |
Member
Author
|
The query is correct, but the other tests were no longer correct. They were not tackled by the malfunction before, but checked the "wrong" values though |
36e7770 to
fa1207b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix that colums of tables of extended classes cannot consider meta attributes, because they are stored according to the iliname - and an attribute of the base class that is used in a table of an extended class has still the iliname of the base class - thats why it now checks its real iliname instead of concatinating it from the tables iliname.
The example illuminates it:
And then extend it:
(or with extra meta attribute file - like in the tests)
Before it created the table from the extended strasse. There it checked "BagOfEnumExt.Strassen.Strasse.Mat" for the entry in the t_ili2db_meta_attr table. But this was wrong. There is no ili-element like this. Mat is definitely an element of BagOfEnumBase.
With the new way of getting the ilielement it's much more stable and fixes this issue.