Add Scripts and Initial Deployment addresses #50
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
It seems optimizations are not enabled.
| if (chainId == vm.envUint("ETHEREUM_SEPOLIA_CHAIN_ID")) return "ethereum-sepolia"; | ||
| if (chainId == vm.envUint("ARBITRUM_SEPOLIA_CHAIN_ID")) return "arbitrum-sepolia"; | ||
| if (chainId == vm.envUint("LINEA_SEPOLIA_CHAIN_ID")) return "linea-sepolia"; | ||
| if (chainId == vm.envUint("SCROLL_SEPOLIA_CHAIN_ID")) return "scroll-sepolia"; | ||
| if (chainId == vm.envUint("OPTIMISM_SEPOLIA_CHAIN_ID")) return "optimism-sepolia"; |
There was a problem hiding this comment.
Seems strange to me to receive these via env vars. Is there a reason not to hardcode them here instead?
|
|
||
| function run() public { | ||
|
|
||
|
|
There was a problem hiding this comment.
Whitespace/formatting is weird in this PR, can you run a Solidity formatter?
| if(block.chainid == targetChainId){ | ||
| return; |
There was a problem hiding this comment.
Wouldn't it make more sense to revert to signal that the script was run with the wrong chain?
No description provided.