8237: Add support for Jolokia over Kubernetes proxy by skarsaune · Pull Request #576 · openjdk/jmc

skarsaune · 2024-08-04T12:05:24Z

JMC-8273 : Use the jolokia protocol over a kubernetes http proxy.

Testing connectivity:

Docker desktop kubernetes
Azure AKS
Amazon EKS
Google GKE

Other things observed:

* Option to install agent should be disabled (debug difference with jolokia) - see below*
* Warning: NLS missing message: JmcKubernetesPreferenceForm_LogErrorsTooltip in: org.openjdk.jmc.kubernetes.preferences.messages
* SLF4J(W): No SLF4J providers were found. OK for now, can investigate more later
SLF4J(W): Defaulting to no-operation (NOP) logger implementation
SLF4J(W): See https://www.slf4j.org/codes.html#noProviders for further details.
Unlocking secrets now appear on startup. Should not be needed unless there are credentials used. (fixed)

Progress

Commit message must refer to an issue
Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

JMC-8237: Add support for Jolokia over Kubernetes proxy (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jmc.git pull/576/head:pull/576
$ git checkout pull/576

Update a local copy of the PR:
$ git checkout pull/576
$ git pull https://git.openjdk.org/jmc.git pull/576/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 576

View PR using the GUI difftool:
$ git pr show -t 576

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jmc/pull/576.diff

Using Webrev

Link to Webrev Comment

bridgekeeper · 2024-08-04T12:06:09Z

👋 Welcome back skarsaune! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2024-08-04T12:06:49Z

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

…proxy" This reverts commit fb352ad.

…proxy" This reverts commit eb19c59.

…-proxy

This reverts commit c81c035.

…-proxy

bridgekeeper · 2024-09-29T12:30:13Z

@skarsaune This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

…ally used

skarsaune · 2024-10-27T08:53:39Z

The cause for the log initialization output is calling Utils.getSystemPropertyOrEnvVar . That is only used very briefly for that very particular use. Can look for alternatives.

skarsaune · 2024-10-28T17:44:22Z

The cause for the log initialization output is calling Utils.getSystemPropertyOrEnvVar . That is only used very briefly for that very particular use. Can look for alternatives.

However, other fabric8.io methods need slf4j quite immediately after that. As the log statement states, it will default to a NOOP logger that we believe is sufficient at this point (problems scanning contexts will manifest themselves as exceptions that should be sufficient to troubleshoot).

skarsaune · 2024-10-29T21:20:27Z

Found the "issue" with the JMC agent.

public boolean isLocalJvm() { return connectionHandle.getServerDescriptor().getJvmInfo() != null; }
Will experiment with not providing getJvmInfo for jolokia and kubernetes

…-proxy

…as a local JVM

bridgekeeper · 2024-12-24T21:59:24Z

@skarsaune This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

skarsaune · 2025-01-02T17:53:36Z

Finding on the Jolokia side. When probing connection k8s API authorization is missing. This can be fixed by using fabric8 http client instead of using OK Http directly.

openjdk · 2025-01-03T09:52:04Z

@skarsaune this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout JMC-8237-kubernetes-proxy
git fetch https://git.openjdk.org/jmc.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

…-proxy

bridgekeeper · 2025-11-09T19:12:23Z

@skarsaune This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper · 2025-12-08T02:19:02Z

@skarsaune This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

aptmac · 2026-01-22T18:54:27Z

application/org.openjdk.jmc.jolokia/src/main/java/org/openjdk/jmc/jolokia/JmcJolokiaPlugin.java

 		JolokiaServiceManager serviceManager = JolokiaServiceManagerFactory.createJolokiaServiceManager(configuration,
 				new JulLogHandler(PLUGIN_ID), new AllowAllRestrictor(),
-				() -> new TreeSet<ServerDetector>(Arrays.asList(ServerDetector.FALLBACK)));
+				logHandleer -> new TreeSet<ServerDetector>(Arrays.asList(ServerDetector.FALLBACK)));


typo, should be "logHandler"

aptmac · 2026-01-22T18:54:46Z

application/org.openjdk.jmc.kubernetes/OSGI-INF/l10n/bundle.properties

@@ -0,0 +1,3 @@
+#Properties file for org.openjdk.jmc.kubernetes
+page.name = Kubernetes
+Bundle-Name = Kubernetes JMC extensions


newline at the end of the file

aptmac · 2026-01-22T18:55:38Z

...njdk.jmc.kubernetes/src/main/java/org/openjdk/jmc/kubernetes/JmcKubernetesJmxConnection.java

+	@Override
+	protected J4pResponse unwrapException(J4pException e) throws IOException, InstanceNotFoundException {
+		// recognize signs of disconnect and signal to the application for better
+		// handling


could the comment be one line?

aptmac · 2026-01-22T18:55:57Z

...org.openjdk.jmc.kubernetes/src/main/java/org/openjdk/jmc/kubernetes/JmcKubernetesPlugin.java

+	@Override
+	public boolean scanForInstances() {
+		// If credentials are locked and credentials are required, the scanner thread
+		// will get hung


this comment could probably be one line less too?

aptmac · 2026-01-22T18:56:19Z

...jdk.jmc.kubernetes/src/main/java/org/openjdk/jmc/kubernetes/KubernetesDiscoveryListener.java

+				new File(System.getProperty("user.home"), ".kube" + File.separator + "config").toString()); //$NON-NLS-1$ //$NON-NLS-2$ //$NON-NLS-3$
+		File configPath = new File(path);
+		if (contexts != null && contextsCached > configPath.lastModified()) {// the YAML parsing is soo incredibly
+																				// sloow, hence cache context names for


the comments here could be moved to fit onto a single line?

aptmac

Finally got around to giving this PR a test, and it's looking good from what I've done so far.

Code-wise it looks good, from a formatting standpoint there's some inconsistency in using new lines with comments, I'll point some out.

I think this is ready for re-testing, the licenses will just need to be updated to be 2026, and potentially the dependencies updated along with rebasing ontop of main.

aptmac · 2026-01-22T18:56:53Z

/open

openjdk · 2026-01-22T18:58:58Z

@aptmac Only the pull request author can set the pull request state to "open"

skarsaune · 2026-01-22T20:54:27Z

/open

openjdk · 2026-01-22T20:55:41Z

@skarsaune This pull request is now open

skarsaune · 2026-01-22T20:56:52Z

Finally got around to giving this PR a test, and it's looking good from what I've done so far.

Code-wise it looks good, from a formatting standpoint there's some inconsistency in using new lines with comments, I'll point some out.

I think this is ready for re-testing, the licenses will just need to be updated to be 2026, and potentially the dependencies updated along with rebasing ontop of main.

Yeah, it has been stale for a bit. I will fix the formatting. I have to merge/rebase and retest everything once #695 is merged.

aptmac · 2026-01-22T21:19:21Z

Great, I sponsored that and it's integrated now

…-proxy

aptmac · 2026-01-23T14:17:14Z

It's stuck on some formatting, it'll fix once you run mvn spotless:apply

skarsaune · 2026-01-23T14:54:02Z

Setting to draft, and resetting test status boxes. Needs retest now.

JMC-8237: Connect with Jolokia protocol over kubernetes HTTP proxy

fb352ad

skarsaune added 4 commits August 4, 2024 21:09

Revert "JMC-8237: Connect with Jolokia protocol over kubernetes HTTP …

626e56f

…proxy" This reverts commit fb352ad.

JMC-8237: Connect with Jolokia protocol over kubernetes HTTP proxy

eb19c59

Revert "JMC-8237: Connect with Jolokia protocol over kubernetes HTTP …

5cc8576

…proxy" This reverts commit eb19c59.

JMC-8237: Connect with Jolokia protocol over kubernetes HTTP proxy

56ba52e

skarsaune changed the title ~~JMC-8237: Connect with Jolokia protocol over kubernetes HTTP proxy~~ JMC-8237: Connect with Jolokia protocol over kubernetes proxy Aug 9, 2024

skarsaune changed the title ~~JMC-8237: Connect with Jolokia protocol over kubernetes proxy~~ JMC-8237: Add support for Jolokia over Kubernetes proxy Aug 9, 2024

openjdk bot changed the title ~~JMC-8237: Add support for Jolokia over Kubernetes proxy~~ 8237: Add support for Jolokia over Kubernetes proxy Aug 9, 2024

skarsaune added 6 commits September 8, 2024 11:56

JMC-8237: Remove unneeded template entries in plugin.xml

a97f7d1

JMC-8237: Remove requirement to unlock credentials on startup

c81c035

Merge remote-tracking branch 'origin/master' into JMC-8237-kubernetes…

39b98bf

…-proxy

JMC-8237: Add kubernetes to 2024-06

0df3c91

Revert "JMC-8237: Remove requirement to unlock credentials on startup"

36fdb91

This reverts commit c81c035.

Merge remote-tracking branch 'origin/master' into JMC-8237-kubernetes…

6b0a03a

…-proxy

thegreystone requested a review from aptmac September 25, 2024 17:10

JMC-8237: Ensure credentials check only occur if credentials are actu…

7dc1b95

…ally used

skarsaune added 5 commits November 16, 2024 21:07

Merge remote-tracking branch 'origin/master' into JMC-8237-kubernetes…

7567c83

…-proxy

JMC-8237: Removed JVM info from descriptor as it will be interpreted …

c815b52

…as a local JVM

JMC-8237: Removed JVM info from descriptor - follow up

cdf6ccf

JMC-8237: Remove unused message

25bc655

JMC-8237: Fixed spotbugs issue

a4ca550

Merge remote-tracking branch 'origin/master' into JMC-8237-kubernetes…

2fed861

…-proxy

bridgekeeper bot closed this Dec 8, 2025

aptmac reviewed Jan 22, 2026

View reviewed changes

openjdk bot reopened this Jan 22, 2026

JMC-8237: PR cleanup: formatting and comments

6227cc0

skarsaune added 3 commits January 22, 2026 22:24

Merge remote-tracking branch 'origin/master' into JMC-8237-kubernetes…

89b2174

…-proxy

JMC-8237: Fixed copyright for this year

846881d

JMC-8237: Fix more copyright years

e40caec

skarsaune marked this pull request as draft January 23, 2026 14:53

openjdk bot removed the rfr label Jan 23, 2026

skarsaune added 5 commits January 25, 2026 10:47

JMC-8237: Fix spotless

384af0c

JMC-8237: Renamed J4p classes to Jolokia

8a30b56

JMC-8237: Use java.util for Base64 (en/de)coding

235e420

JMC-8237: spotless:apply

a37d4b2

JMC-8237: More jolokia class corrections

d636e88

Conversation

skarsaune commented Aug 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewing

Uh oh!

bridgekeeper bot commented Aug 4, 2024

Uh oh!

openjdk bot commented Aug 4, 2024

Uh oh!

bridgekeeper bot commented Sep 29, 2024

Uh oh!

skarsaune commented Oct 27, 2024

Uh oh!

skarsaune commented Oct 28, 2024

Uh oh!

skarsaune commented Oct 29, 2024

Uh oh!

bridgekeeper bot commented Dec 24, 2024

Uh oh!

skarsaune commented Jan 2, 2025

Uh oh!

openjdk bot commented Jan 3, 2025

Uh oh!

bridgekeeper bot commented Nov 9, 2025

Uh oh!

bridgekeeper bot commented Dec 8, 2025

Uh oh!

aptmac Jan 22, 2026

Choose a reason for hiding this comment

Uh oh!

aptmac Jan 22, 2026

Choose a reason for hiding this comment

Uh oh!

aptmac Jan 22, 2026

Choose a reason for hiding this comment

Uh oh!

aptmac Jan 22, 2026

Choose a reason for hiding this comment

Uh oh!

aptmac Jan 22, 2026

Choose a reason for hiding this comment

Uh oh!

aptmac left a comment

Choose a reason for hiding this comment

Uh oh!

aptmac commented Jan 22, 2026

Uh oh!

openjdk bot commented Jan 22, 2026

Uh oh!

skarsaune commented Jan 22, 2026

Uh oh!

openjdk bot commented Jan 22, 2026

Uh oh!

skarsaune commented Jan 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aptmac commented Jan 22, 2026

Uh oh!

aptmac commented Jan 23, 2026

Uh oh!

skarsaune commented Jan 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

2 participants

skarsaune commented Aug 4, 2024 •

edited

Loading

skarsaune commented Jan 22, 2026 •

edited

Loading