Skip to content

Conversation

@james-elicx
Copy link
Collaborator

@james-elicx james-elicx commented Jan 23, 2026

If the the adapters api fixRequire patch is applied, __require is replaced with require, which results in the patch to replace the cache handler paths failing to match.

@james-elicx james-elicx marked this pull request as ready for review January 23, 2026 20:53
@pkg-pr-new
Copy link

pkg-pr-new bot commented Jan 24, 2026

Open in StackBlitz

npm i https://pkg.pr.new/@opennextjs/cloudflare@1
npm i https://pkg.pr.new/@opennextjs/aws@1

commit: db9b613

@james-elicx james-elicx requested review from conico974 and vicb January 26, 2026 07:52
@vicb
Copy link
Contributor

vicb commented Jan 26, 2026

Is this really required for the adapters API?

We used to do that to override the cache handler.
But with the adapters API, we should be able to set the cache handler(s) directly in the the Next config

@vicb
Copy link
Contributor

vicb commented Jan 26, 2026

I'm not against merging that if it helps for now but there should be a follow up issue to clean that up.

But I think this is already handled at https://github.com/opennextjs/opennextjs-cloudflare/blob/adapters-api/packages/cloudflare/src/cli/adapter.ts#L80

@james-elicx
Copy link
Collaborator Author

To be honest I didn't go far enough to check that, it was just from when I was seeing if the e2es still ran with no changes. I'll close this if the thinking is that cache handler will no longer be an issue once adapters api is used properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants