Add query role privilege #256
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # DESCRIPTION # NEWS.md # inst/golem-config.yml
jthompson-arcus
requested changes
Jan 5, 2026
Collaborator
jthompson-arcus
left a comment
jthompson-arcus
left a comment
There was a problem hiding this comment.
As I understand it, this role is meant to restrict query creation and resolution. But any user can still respond to queries correct?
Comment on lines
+797
to
+798
| if (file.exists("clinsight-config.yml")) { | ||
| "clinsight-config.yml" |
Collaborator
There was a problem hiding this comment.
This change should be documented in the Deployment vignette.
Comment on lines
+70
to
+75
| observeEvent(r$user_role, { | ||
| shinyjs::toggleElement( | ||
| "resolved", | ||
| condition = get_roles_from_config()[r$user_role] %in% get_golem_config("allow_to_query") | ||
| ) | ||
| }) |
Collaborator
There was a problem hiding this comment.
This only causes the checkbox to not be displayed. A user could in their browser make the checkbox visible and still "resolve" a query even without the permissions.
Collaborator
There was a problem hiding this comment.
Actually realizing there's not a ton a server side verification being done here. I'm also able to comment on "resolved" queries as well just by removing the disabled attribute in the browser.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17.
allow_to_query()role cannot close queries.clinsight-config.ymland using that before falling back to the defaultgolem-config.ymlfile in the package