Draft
Conversation
Motor configs are not detected. Create a simulation in openrocket file. Use pathways associated with your workflow in the py code.
Member
Author
|
Note that this is a PR of @Ansley-Paul. The code contains problems, like using absolute file paths. I haven't looked into the code in any way, other than a quick glance. |
|
You can also configure the pathways using the steps that were given in the readme file of setup of orhelper instead, and those paths in my version of the code could just be commented out. The only path needed would be to the rocketry file that you are extracting information from, that would have to be specified in the code. |
|
My PR aims to debug the original code, and make the Monte Carlo Simulations run, which the original code does not do. There is only 1 issue in my main code: I have debugged everything except the motor configs that are not being detected by montecarlo.py. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motor configs are not detected. Create a simulation in openrocket file. Use pathways associated with your workflow in the py code.