Move migrations to Procfile #2457
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucyb
force-pushed
the
run-migrations-in-release-phase
branch
from
754225a to
6c02845
Compare
Dokku recommends that database migrations are not done during deployment, but before an app is deployed. They recommend that the migrations are applied during the "release" phase. This should stop deployments failing due to health checks timing out during a long running migration. Refs: #2393 TODO: - [] test change - [] figure out how to test migrations in CI - [x] ensure migrations are still run in local dev
The logic for this was moved into deploy/prod.sh in the previous commit. This is now executed during the release phase of a deployment using Dokku.
lucyb
force-pushed
the
run-migrations-in-release-phase
branch
from
4aee33e to
6edd1b9
Compare
Contributor
Author
|
I've tried to test this change using Steve's PR to run it in devcontainers (with some small tweaks). However, this isn't pulling in the Profile, so I don't know if that's configured correctly (which is the part that I really want to test). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dokku recommends that database migrations are not done during deployment, but before an app is deployed. They recommend that the migrations are applied during the "release" phase. This should stop deployments failing due to health checks timing out during a long running migration.
Refs: #2393
TODO: