fix: Update System.env syntax for Gradle 9 compatibility#841
Open
dbwiddis wants to merge 1 commit intoopensearch-project:mainfrom
Open
fix: Update System.env syntax for Gradle 9 compatibility#841dbwiddis wants to merge 1 commit intoopensearch-project:mainfrom
dbwiddis wants to merge 1 commit intoopensearch-project:mainfrom
Conversation
Signed-off-by: Daniel Widdis <widdis@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #841 +/- ##
============================================
- Coverage 70.88% 70.01% -0.87%
- Complexity 421 489 +68
============================================
Files 49 54 +5
Lines 3125 3518 +393
Branches 194 228 +34
============================================
+ Hits 2215 2463 +248
- Misses 785 911 +126
- Partials 125 144 +19 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the Gradle build files to fix compatibility with Gradle 9.
Problem
The current syntax using
$System.env.VARIABLE_NAMEfor accessing environment variables is not compatible with Gradle 9.This format is used in this repository for Sonatype credentials for SNAPSHOT publication. This fails with under Gradle 9.
See example failed workflow here.
Solution
Update to use the
System.getenv()method instead:Example fix which restored successful snapshots: opensearch-project/opensearch-remote-metadata-sdk#245