Skip to content

Conversation

@kalynstricklin
Copy link
Contributor

No description provided.

@alexrobin
Copy link
Member

@kalynstricklin The sensorhub-comm-mqtt module was meant to contain only generic MQTT APIs, while implementation specific stuff would live in other modules (for example, the HiveMQ server module).

I think in your case you could create a module called sensorhub-service-mqtt-paho or perhaps sensorhub-comm-mqtt-paho since it looks like it's only client-side stuff.

@kalynstricklin
Copy link
Contributor Author

perf! thank you!

@@ -0,0 +1,210 @@
package com.botts.impl.comm.mqtt;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add license headers to files

}

/**
*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fill in all the javadoc blocks or just remove them

@DisplayInfo(label="Retain", desc="Check to allow MQTT broker to store the last message sent on the specific topic")
public boolean retain;

@DisplayInfo(label="Clean Session", desc="Check ")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add real descriptions to these or remove

@@ -1,6 +1,19 @@
description = 'MQTT Service API'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should restore this to its previous version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants