Skip to content

Ensure we do a string check of the is_rename value #492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
komish merged 1 commit into from
Feb 3, 2026
Merged

Ensure we do a string check of the is_rename value #492

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/workflows/mercury_bot.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ jobs:
- name: Assert renaming semantics
id: assert-rename-semantics
if: |
steps.populate-file-mod-type.outputs.is-rename
steps.populate-file-mod-type.outputs.is-rename == 'true'
&& steps.determine-lock-status.outputs.chart-is-locked == 'true'
env:
PREVIOUS_FILENAME: ${{ steps.populate-file-mod-type.outputs.previous-filename && steps.populate-file-mod-type.outputs.previous-filename || 'unset' }}
Expand All @@ -142,7 +142,6 @@ jobs:
run: |
echo "Current lock is set to ${CURRENT_LOCK}"
echo "The previous filename for this rename is: ${PREVIOUS_FILENAME}"
echo "The new chart name is consistent through the namespace rename: ${CHART_NAME_CONSISTENT}"
echo locked-to-previous-filename="${LOCKED_TO_PREVIOUS}" | tee -a $GITHUB_OUTPUT

# Do not merge net-new OWNERS files for locked chart names. Allow a
Expand Down
Loading