[kubevirtci]: refactor cluster-sync target to work with kubevirtci#85
[kubevirtci]: refactor cluster-sync target to work with kubevirtci#85enp0s3 wants to merge 5 commits intoopenshift-virtualization:mainfrom
Conversation
Signed-off-by: Igor Bezukh <ibezukh@redhat.com>
Signed-off-by: Igor Bezukh <ibezukh@redhat.com>
this file intedned for the ephemeral local cluster setup therefore it doesn't impose any security breach by exposing it in the repo. Signed-off-by: Igor Bezukh <ibezukh@redhat.com>
added scripts in hack directory to comply with kubevirtci dependencies Signed-off-by: Igor Bezukh <ibezukh@redhat.com>
kubevirt deployment moved to cluster-sync. sync.sh clean.sh install.sh are now working with kubevirtci. KUBEVIRT_RELEASE is now defined in common.sh fixed default image url for make manifests its now the internal registry URL of kubevirtci. Signed-off-by: Igor Bezukh <ibezukh@redhat.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Barakmor1
left a comment
Barakmor1
left a comment
There was a problem hiding this comment.
Looks great! I added a few small comments. Also, I'll create an issue to automatically update the builder image as a post-submit job when it's changed.
| ARCHITECTURE="${BUILD_ARCH:-$(uname -m)}" | ||
| HOST_ARCHITECTURE="$(uname -m)" | ||
| WASP_CRI="$(determine_wasp_bin)" | ||
| KUBEVIRT_RELEASE=${KUBEVIRT_RELEASE:-"latest_nightly"} |
There was a problem hiding this comment.
WDYT about changing this the latest_stable i think that it's good enough since wasp is not coupled with kubevirt.
|
There are some leftovers on ./cluster-up dir |
2 participants
Signed-off-by: Igor Bezukh ibezukh@redhat.com
Depends on #84
cluster-sync now deploys kubevirt. KUBEVIRT_RELEASE is now defined in common.sh
cluster-sync scripts are now synced with the kubevirtci repo