Disable EventedPLEG featuregate in techpreview#1483
Disable EventedPLEG featuregate in techpreview#1483openshift-merge-robot merged 1 commit intoopenshift:masterfrom
Conversation
|
Hello @JoelSpeed! Some important instructions when contributing to openshift/api: |
|
@JoelSpeed: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoelSpeed, sairameshv The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
The issue while enabling the |
In combination with openshift/machine-config-operator#3688, this was causing an issue in TechPreview clusters.
Myself and @sergiordlr both observed that, when enabled in the cluster by the machine-config-operator, this feature gate got passed through to the Kubelet and weird interactions were happening between kubelet and crio causing odd behaviour and duplicate containers/bind address issues.
In my testing, disabling this feature lead to a healthy cluster within 3688. In these test runs the tech preview clusters bootstrapped correctly where previously they had been failing to bootstrap, this run was against a commit that deliberately excluded passing
EventedPLEGto the kubelet.Discussion in slack here and here
If we exclude the feature for now, once 3688 has merged, we can reintroduce this and test via a PR to cluster-config-operator to make sure track any issues being caused. Currently, because MCO was not up to date, it had not been able to be tested in the cluster pre-merge.
CC @harche @sairameshv