build(deps): bump github.com/openshift-online/ocm-cli from 1.0.10 to 1.0.11#891
Conversation
dependabot
bot
added
area/dependency
|
Hi @dependabot[bot]. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dependabot[bot] The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Bumps [github.com/openshift-online/ocm-cli](https://github.com/openshift-online/ocm-cli) from 1.0.10 to 1.0.11. - [Release notes](https://github.com/openshift-online/ocm-cli/releases) - [Changelog](https://github.com/openshift-online/ocm-cli/blob/main/CHANGES.md) - [Commits](openshift-online/ocm-cli@v1.0.10...v1.0.11) --- updated-dependencies: - dependency-name: github.com/openshift-online/ocm-cli dependency-version: 1.0.11 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
force-pushed
the
dependabot/go_modules/github.com/openshift-online/ocm-cli-1.0.11
branch
from
c1f3c3c to
7b0428f
Compare
WalkthroughUpdated go.mod with direct and indirect dependency version bumps across multiple modules. Key direct dependency updates include ocm-cli (v1.0.10 → v1.0.11), spf13/cobra (v1.10.1 → v1.10.2), and k8s.io/apimachinery (v0.30.3 → v0.34.3). Numerous indirect dependencies also received version upgrades. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@go.mod`:
- Around line 33-36: Update the Kubernetes dependency set so all k8s.io modules
use the same minor version: change the k8s.io/apimachinery entry from v0.34.3 to
v0.30.3 to match k8s.io/api, k8s.io/cli-runtime, and k8s.io/client-go; ensure
go.mod is updated accordingly and run `go mod tidy` to reconcile module graph
and vendor files.
| k8s.io/api v0.30.3 | ||
| k8s.io/apimachinery v0.30.3 | ||
| k8s.io/apimachinery v0.34.3 | ||
| k8s.io/cli-runtime v0.30.3 | ||
| k8s.io/client-go v0.30.3 |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
cat go.mod | head -50Repository: openshift/backplane-cli
Length of output: 1949
🏁 Script executed:
rg -n "k8s\.io" go.modRepository: openshift/backplane-cli
Length of output: 712
🌐 Web query:
kubernetes k8s.io version compatibility requirements apimachinery api client-go alignment
💡 Result:
- Pin
k8s.io/client-go,k8s.io/apimachinery, andk8s.io/apito the same Kubernetes minor (and ideally same patch) tag. These repos are synced from Kubernetesstaging/and are intended to be consumed as a matched set; mixing minors is a common cause of scheme/serialization/type and generated-client breakage. In particular,client-goexplicitly depends on companion libs (apimachinery,api) and says they must be vendored in “correspondingly matching versions”. [1][2] - Recommended alignment rule (Go modules): use the matching semver tags:
- Kubernetes
v1.X.Y↔k8s.io/client-go v0.X.Y(and typicallyk8s.io/api v0.X.Y,k8s.io/apimachinery v0.X.Y).client-gopublishes matching tags and explains thatkubernetes-1.X.Yandv0.X.Ycorrespond to the same staged code. [1]
- Kubernetes
- Do not rely on cross-version API compatibility guarantees for
apimachinery(or otherk8s.io/*staging libs).apimachinerystates there are no compatibility guarantees and that branches track Kubernetes. Treat it as “must match Kubernetes/client-go”. [3] - Cluster compatibility is broader than library compatibility.
client-goprovides a “compatibility matrix” showing “exact match” vs “skew” behavior across Kubernetes versions, and notes older clients often work with newer clusters due to Kubernetes’ backward compatibility—but that’s separate from the requirement to keep the Go modules (api/apimachinery/client-go) aligned with each other. [1]
Practical requirement: pick one Kubernetes minor X and keep all k8s.io/{client-go,api,apimachinery} at v0.X.* (same X; preferably same patch *) to avoid mismatched generated types/schemes/negotiation code. [1][3]
Sources:
[1] kubernetes/client-go README (versioning + compatibility matrix + matching tags) (github.com)
[2] “Introducing client-go version 6” (client-go requires matching api/apimachinery versions) (kubernetes.io)
[3] pkg.go.dev k8s.io/apimachinery (explicitly: no compatibility guarantees; tracks Kubernetes) (pkg.go.dev)
Citations:
- 1: https://github.com/kubernetes/client-go?utm_source=openai
- 2: https://kubernetes.io/blog/2018/01/introducing-client-go-version-6/?utm_source=openai
- 3: https://pkg.go.dev/k8s.io/apimachinery?utm_source=openai
Kubernetes package version mismatch: align k8s.io/apimachinery with other k8s.io packages.
k8s.io/apimachinery v0.34.3 is misaligned with k8s.io/api v0.30.3, k8s.io/cli-runtime v0.30.3, and k8s.io/client-go v0.30.3. These packages are synced from Kubernetes staging/ and must be consumed as a matched set at the same minor version. Kubernetes explicitly documents that mixing minors is a common cause of scheme, serialization, and type conflicts. Update k8s.io/apimachinery to v0.30.3 to match the others.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@go.mod` around lines 33 - 36, Update the Kubernetes dependency set so all
k8s.io modules use the same minor version: change the k8s.io/apimachinery entry
from v0.34.3 to v0.30.3 to match k8s.io/api, k8s.io/cli-runtime, and
k8s.io/client-go; ensure go.mod is updated accordingly and run `go mod tidy` to
reconcile module graph and vendor files.
|
@dependabot[bot]: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Bumps github.com/openshift-online/ocm-cli from 1.0.10 to 1.0.11.
Release notes
Sourced from github.com/openshift-online/ocm-cli's releases.
Changelog
Sourced from github.com/openshift-online/ocm-cli's changelog.
Commits
6758645Release v1.0.11 (#1007)9384236[OCM-21962](https://issues.redhat.com/browse/OCM-21962) | feat: Support create/edit clusters with channel flag (#1003)8cfd3aefix missing gcp credentials when using --service-account-file (#979)b464896Merge pull request #810 from openshift-online/konflux/mintmaker/main/github.c...c625fe9Merge pull request #958 from openshift-online/konflux/mintmaker/main/github.c...d3aab8fMerge pull request #957 from openshift-online/konflux/mintmaker/main/github.c...707c063Merge pull request #956 from openshift-online/konflux/mintmaker/main/github.c...f4a651fMerge pull request #955 from openshift-online/konflux/mintmaker/main/aws-sdk-...d0c3188Merge pull request #954 from openshift-online/konflux/mintmaker/main/github.c...6b5dc3ffix(deps): update module github.com/onsi/ginkgo/v2 to v2.27.5 (#960)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)