SREP-3558: Fix setup-envtest installation and usage#681
Merged
openshift-merge-bot[bot] merged 3 commits intoopenshift:masterfrom Feb 25, 2026
Merged
SREP-3558: Fix setup-envtest installation and usage#681openshift-merge-bot[bot] merged 3 commits intoopenshift:masterfrom
openshift-merge-bot[bot] merged 3 commits intoopenshift:masterfrom
Conversation
- Update ENVTEST_K8S_VERSION to 1.28.0 and ENVTEST_VERSION to release-0.23 - Install setup-envtest to GOPATH/bin if not present - Improve kubebuilder test assets setup with proper error handling - Specify architecture and OS for cross-platform compatibility 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
joshbranham
reviewed
Feb 24, 2026
| $(eval KUBEBUILDER_ASSETS := "$(shell $(SETUP_ENVTEST) use $(ENVTEST_K8S_VERSION) -p path --bin-dir /tmp/envtest/bin)") | ||
| @if [ ! -f "$(SETUP_ENVTEST)" ]; then \ | ||
| echo "Installing setup-envtest..."; \ | ||
| GOBIN=$(GOPATH)/bin go install sigs.k8s.io/controller-runtime/tools/setup-envtest@latest; \ |
Contributor
There was a problem hiding this comment.
Why are we installing the latest version?
Contributor
Author
There was a problem hiding this comment.
updated it to match the version used in the Dockerfile
joshbranham
reviewed
Feb 24, 2026
| CONTROLLER_GEN_VERSION="v0.16.4" \ | ||
| OPENAPI_GEN_VERSION="v0.29.15" \ | ||
| ENVTEST_VERSION="release-0.18" \ | ||
| ENVTEST_VERSION="release-0.23" \ |
Contributor
There was a problem hiding this comment.
Did you build the dockerfile locally to see if it passes?
Contributor
Author
|
/label tide/merge-method-squash |
Contributor
Author
|
/retest |
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abyrne55, eth1030 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the CI failures encountered when bumping boilerplate to b1b2a7f89ab7147bf8782b1fd1554126c567f2d4. The base image was updated which broke envtest.
🤖 Generated with Claude Code
Testing
build local boilerplate image
build gcp-project-operator using local boilerplate image
run tests
all tests also pass when running