Skip to content

Comments

fix(cli): return exit code 1 on failure instead of 255#312

Open
smith-xyz wants to merge 1 commit intoopenshift:mainfrom
smith-xyz:gh-218
Open

fix(cli): return exit code 1 on failure instead of 255#312
smith-xyz wants to merge 1 commit intoopenshift:mainfrom
smith-xyz:gh-218

Conversation

@smith-xyz
Copy link
Contributor

Closes #218

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 22, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: smith-xyz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 22, 2026
main.go Outdated
Short: "Scan a local unpacked image bundle",
Use: "local",
Short: "Scan a local unpacked image bundle",
SilenceUsage: true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this related to the fix?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for catching, not related - reverted

)

const (
defaultPayloadFilename = "payload.json"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this related to the fix?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for catching, not related - reverted

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 23, 2026

@smith-xyz: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Errors are not properly propagated causing app to re-execute cmds

2 participants