-
Notifications
You must be signed in to change notification settings - Fork 65
build_suggestions: bump 4.21 minimum upgrade version to 4.20.12 #8624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
so upgrades go through openshift/machine-config-operator#5516 Signed-off-by: Peter Hunt <pehunt@redhat.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Comment |
|
context: in cri-o 1.33, a change cri-o/cri-o#8962 was made to the default limits set for CRI-O. Now, the ulimit nofile is set much lower, with space to set it higher. however, some workloads don't expect this change, and fail (see https://issues.redhat.com/browse/OCPBUGS-62095) This was worked around temporarily in openshift/machine-config-operator#5308, but that workaround was not intendd to be carried in to 4.21. Instead, we should drop-in an ignition file on upgrades from 4.20 to 4.21 to make sure existing clusters don't get this change, but new clusters started in 4.21 do. Now we need to make sure upgrades go through that PR. it missed 4.20.11 by a day, so I feel confident it will land in 4.20.12 |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: haircommander The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@haircommander: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| @@ -1,5 +1,5 @@ | |||
| default: | |||
| minor_min: 4.20.8 | |||
| minor_min: 4.20.12 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does look like OCPBUGS-70201 missed 4.20.11. So we expect it to be in 4.20.12. But let's wait until 4.20.12 exists, so we can confirm for sure, because sometimes ART picks special things as the source of a release image.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works for me, as long as we can get something like this in for upgrades to 4.21.0
/hold
so upgrades go through openshift/machine-config-operator#5516