SREP-3023 : Fix skipped LB reconciliation e2e test#433
SREP-3023 : Fix skipped LB reconciliation e2e test#433rpodishe wants to merge 1 commit intoopenshift:masterfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: rpodishe The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@rpodishe: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #433 +/- ##
=======================================
Coverage 41.57% 41.57%
=======================================
Files 27 27
Lines 2665 2665
=======================================
Hits 1108 1108
Misses 1478 1478
Partials 79 79 🚀 New features to boost your workflow:
|
Ticket - https://issues.redhat.com/browse/SREP-3023
reconciliation test, leaving pollingDuration (2 min) unchanged for all
other tests
use lbReconcileTimeout instead of pollingDuration
is nil (forwarding rule already absent at test start), the comparison
newLB.Name != oldLB.Name panics. Added oldLB == nil guard.