Skip to content

Comments

SREP-3023 : Fix skipped LB reconciliation e2e test#433

Open
rpodishe wants to merge 1 commit intoopenshift:masterfrom
rpodishe:SREP-3023-fix-cloud-ingress-operator
Open

SREP-3023 : Fix skipped LB reconciliation e2e test#433
rpodishe wants to merge 1 commit intoopenshift:masterfrom
rpodishe:SREP-3023-fix-cloud-ingress-operator

Conversation

@rpodishe
Copy link

Ticket - https://issues.redhat.com/browse/SREP-3023

  • Add lbReconcileTimeout = 10 * time.Minute constant dedicated to the LB
    reconciliation test, leaving pollingDuration (2 min) unchanged for all
    other tests
  • Remove ginkgo.Skip("skip test pending OSD-29874")
  • Update 3 PollUntilContextTimeout calls in the LB test (1 AWS, 2 GCP) to
    use lbReconcileTimeout instead of pollingDuration
  • Fix nil pointer dereference in GCP forwarding rule comparison: when oldLB
    is nil (forwarding rule already absent at test start), the comparison
    newLB.Name != oldLB.Name panics. Added oldLB == nil guard.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 23, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rpodishe
Once this PR has been reviewed and has the lgtm label, please assign luis-falcon for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 23, 2026

@rpodishe: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@codecov
Copy link

codecov bot commented Feb 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 41.57%. Comparing base (6d47107) to head (77050aa).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #433   +/-   ##
=======================================
  Coverage   41.57%   41.57%           
=======================================
  Files          27       27           
  Lines        2665     2665           
=======================================
  Hits         1108     1108           
  Misses       1478     1478           
  Partials       79       79           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant