OCPBUGS-67285: .gitignore shouldn't ignore files in /vendor/**/kubeco…

[mbiarnes]

…nfig

Backport of #112

[openshift-ci-robot]

@mbiarnes: This pull request references Jira Issue OCPBUGS-56726, which is invalid:

• expected the bug to target the "4.19.0" version, but no target version was set
• release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
• expected Jira Issue OCPBUGS-56726 to depend on a bug targeting a version in 4.20.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

…nfig

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[mbiarnes]

/test security

[mbiarnes]

/test okd-scos-e2e-aws-ovn

[mbiarnes]

/jira-refresh

[openshift-bot]

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[mbiarnes]

/remove-lifecycle stale

[mbiarnes]

/retest-required

[openshift-bot]

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[openshift-bot]

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

[openshift-bot]

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

[openshift-ci]

@openshift-bot: Closed this PR.

Details

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci-robot]

@mbiarnes: This pull request references Jira Issue OCPBUGS-56726. The bug has been updated to no longer refer to the pull request using the external bug tracker. All external bug links have been closed. The bug has been moved to the NEW state.

Details

In response to this:

…nfig

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@mbiarnes: This pull request references Jira Issue OCPBUGS-56726, which is invalid:

• release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
• expected Jira Issue OCPBUGS-56726 to depend on a bug targeting a version in 4.20.0, 4.20.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

…nfig

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[damdo]

Hey @mbiarnes thanks for the PR!

It looks good, only one comment.

Though we need to update this to play nice with the fact that this is a soft-fork repo that we keep in sync with our upstream.

Could you please split this PR into 2 commit with the following commit title and structure to be compatible with the bot:

• one for the .gitignore change with commit title UPSTREAM: <carry>: unignore vendor kubeconfig
• one for the vendor changes with commit title UPSTREAM: <drop>: go mod vendor

Thanks!

[damdo]

Can we ignore only the kubeconfigs inside vendor to avoid potential issues? TY

[mbiarnes]

@damdo now you should have two related commits .
Please check the .gitignore file - it is the very same as before - if there is something missing now, I would say it is better to do a new PR.

[damdo]

Looks good! Thanks @mbiarnes

[damdo]

/approve
/lgtm

[openshift-ci]

@damdo: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

• ci/prow/security

Only the following failed contexts/checkruns were expected:

• ci/prow/generate
• ci/prow/govet
• ci/prow/images
• ci/prow/okd-scos-images
• ci/prow/unit
• ci/prow/verify-deps
• pull-ci-openshift-cluster-api-provider-ibmcloud-main-generate
• pull-ci-openshift-cluster-api-provider-ibmcloud-main-govet
• pull-ci-openshift-cluster-api-provider-ibmcloud-main-images
• pull-ci-openshift-cluster-api-provider-ibmcloud-main-okd-scos-images
• pull-ci-openshift-cluster-api-provider-ibmcloud-main-unit
• pull-ci-openshift-cluster-api-provider-ibmcloud-main-verify-deps
• tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

Details

In response to this:

/override ci/prow/security

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[mbiarnes]

/verified

[openshift-ci-robot]

@mbiarnes: The /verified command must be used with one of the following actions: by, later, remove, or bypass. See https://docs.ci.openshift.org/docs/architecture/jira/#premerge-verification for more information.

Details

In response to this:

/verified

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[damdo]

/verified by images job passing

[openshift-ci-robot]

@damdo: This PR has been marked as verified by images job passing.

Details

In response to this:

/verified by images job passing

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[damdo]

/jira refresh

[openshift-ci-robot]

@damdo: This pull request references Jira Issue OCPBUGS-56726, which is invalid:

• expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Verified instead
• expected Jira Issue OCPBUGS-56726 to depend on a bug targeting a version in 4.20.0, 4.20.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@mbiarnes: This pull request references Jira Issue OCPBUGS-67285, which is invalid:

• expected the bug to be open, but it isn't
• expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Closed (Done) instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

…nfig

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[damdo]

/jira refresh

[openshift-ci-robot]

@damdo: This pull request references Jira Issue OCPBUGS-67285, which is valid.

7 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.19.z) matches configured target version for branch (4.19.z)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
• release note type set to "Release Note Not Required"
• dependent bug Jira Issue OCPBUGS-76379 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
• dependent Jira Issue OCPBUGS-76379 targets the "4.20.0" version, which is one of the valid target versions: 4.20.0, 4.20.z
• bug has dependents

Requesting review from QA contact:
/cc @sunzhaohua2

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[damdo]

/hold

[damdo]

@mbiarnes

Looking closer at the changes in your PR, it looks like we had a similar fix PR for 4.18 and 4.20, so this would be the one in the middle for 4.19

• 4.20 fix: OCPBUGS-76379: Do not gitignore files inside vendor #112
• 4.18 fix: OCPBUGS-67286: [release-4.18] Fix incomplete vendor/ #140

So your fix should do the same actually, to be consistent across releases

Could you redo your changes here to follow: #112 ?

Still doing the two commits with the titles described? TY

[damdo]

I've already fixed the bug chain

[mbiarnes]

@damdo
hope this is all good

[openshift-ci]

@mbiarnes: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/okd-scos-e2e-aws-ovn	0558603	link	false	/test okd-scos-e2e-aws-ovn
ci/prow/security	0558603	link	true	/test security
ci/prow/okd-scos-images	c184eb2	link	true	/test okd-scos-images

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[damdo]

Yes looks good!
Thanks!

/lgtm

[damdo]

/verified by images job passing