Skip to content

Comments

SPLAT-2410: Change annotation from feature-set to feature-gate#83

Open
AnnaZivkovic wants to merge 3 commits intoopenshift:masterfrom
AnnaZivkovic:change-feature-gate
Open

SPLAT-2410: Change annotation from feature-set to feature-gate#83
AnnaZivkovic wants to merge 3 commits intoopenshift:masterfrom
AnnaZivkovic:change-feature-gate

Conversation

@AnnaZivkovic
Copy link

Enable deployment of Cluster API operator components when using ClusterAPIMachineManagement feature gate. This allows the operator to run on clusters with any featureSet that has ClusterAPIMachineManagement feature-gate enabled.

This is related to openshift/cluster-capi-operator#465

@AnnaZivkovic AnnaZivkovic changed the title Change annotation from feature-set to feature-gate SPLAT-2410: Change annotation from feature-set to feature-gate Feb 23, 2026
@openshift-ci openshift-ci bot requested review from damdo and racheljpg February 23, 2026 18:55
@openshift-ci
Copy link

openshift-ci bot commented Feb 23, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AnnaZivkovic
Once this PR has been reviewed and has the lgtm label, please assign joelspeed for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 23, 2026
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 23, 2026

@AnnaZivkovic: This pull request references SPLAT-2410 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Enable deployment of Cluster API operator components when using ClusterAPIMachineManagement feature gate. This allows the operator to run on clusters with any featureSet that has ClusterAPIMachineManagement feature-gate enabled.

This is related to openshift/cluster-capi-operator#465

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Enable deployment of Cluster API operator components when using ClusterAPIMachineManagement feature gate. This allows the operator to run on clusters with any featureSet that has ClusterAPIMachineManagement feature-gate enabled.
….0-20260211173825-b82eff130f3e

Update the manifests-gen tool dependency to the latest version which:
   - Removes hardcoded feature-set annotations from generated manifests

This aligns with the upstream changes that eliminate the CustomNoUpgraded and TechPreviewNoUpgrade feature-set annotations, allowing the operator to work with feature-gate based deployments ClusterAPIMachineManagement feature-gate enabled.
Update Makefile flags and manager image to work with the new manifests-gen tool version.
@openshift-ci
Copy link

openshift-ci bot commented Feb 24, 2026

@AnnaZivkovic: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-vsphere-techpreview ec623db link true /test e2e-vsphere-techpreview
ci/prow/okd-scos-images ec623db link true /test okd-scos-images
ci/prow/images ec623db link true /test images
ci/prow/e2e-vsphere-capi-techpreview ec623db link true /test e2e-vsphere-capi-techpreview
ci/prow/e2e-vsphere-serial ec623db link true /test e2e-vsphere-serial
ci/prow/regression-clusterinfra-vsphere-ipi-techpreview-capi ec623db link false /test regression-clusterinfra-vsphere-ipi-techpreview-capi

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants