Add azure images#46
Add azure images#46openshift-merge-robot merged 3 commits intoopenshift:masterfrom lobziik:azure-images
Conversation
|
I spoke with @Danil-Grigorev yesterday, would it be better to have a single image for Azure but with the two binaries in it? This would make the image substitution easier IIUC. This is something we have done with other things like spot termination handlers as part of MAO |
|
Agree, it would be easier. I'm mostly doubting about delivering ccm binary to worker nodes... Don't think that it might cause big issues but would prefer to keep it separate. Also building windows binary in future might require special treatment, but I'm not sure there. For additional context: |
|
This might be another thing kubernetes-sigs/cloud-provider-azure#580 - we might want to use different images for different node types (e.g arm) |
manifests/0000_26_cloud-controller-manager-operator_01_images.configmap.yaml
Show resolved
Hide resolved
https://coreos.slack.com/archives/CM4ERHBJS/p1620994660139000 сс @lobziik We are not required to run azure for windows nodes yet. |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
| type OperatorConfig struct { | ||
| ManagedNamespace string | ||
| ControllerImage string | ||
| CloudNodeImage string |
There was a problem hiding this comment.
I think this one will be better named CloudNodeControllerImage
|
Suggest to rewiew and merge it for now as well as #45 Gonna introduce finished refactoring with interface (https://github.com/lobziik/cluster-cloud-controller-manager-operator/pull/1) as follow up, would be way more convenient for development and review. |
|
/lgtm |
openshift-ci
bot
added
lgtm
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Danil-Grigorev, elmiko The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
5 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@lobziik: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
6 participants
Add azure images to images configmap and image-reference file