OCPCLOUD-1194: Implement cloud-config-file flag in CCCMO render#55
Conversation
8d0469b to
d437b3c
Compare
d437b3c to
270a5a5
Compare
270a5a5 to
2ba70cc
Compare
2ba70cc to
2625bc2
Compare
|
/lgtm |
elmiko
left a comment
There was a problem hiding this comment.
mostly looks good, i just have a minor suggestion for the help text.
3fbd1d3 to
8ad771f
Compare
|
@elmiko Added your suggestion. PTAL |
elmiko
left a comment
There was a problem hiding this comment.
thanks @Danil-Grigorev !
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: elmiko, Fedosin The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@Danil-Grigorev: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Based on #56 and #48, both are required to merge before that.
Introduces a new flag:
This implementation will unconditionally create a
{destination_dir}/configdirectory which would be used as a source of files to copy into/etc/kubernetes/bootstrap-configsdirectory on bootstrap VM.Based on the information from the
Infrastructureresource provided from--cluster-infrastructure-filethe--cloud-config-fileconfigMap would be read, unpacked and stored into{destination_dir}/config/cloud.config. Each provider explicitly requiring this, would be able to mount/etc/kubernetes/bootstrap-configsdirectory, and read the content fromcloud.conf. example is Azure CCM.Implementation is copied from MCO which served as a mean to pass cloud config to master ignition file.
To test this PR on Azure, check out installer PR, and do: