OCPBUGS-13547: Require consistency in rendered artifacts

go.mod

@@ -8,7 +8,7 @@ require (
 	github.com/openshift/api v0.0.0-20230426193520-54a14470e5dc
 	github.com/openshift/build-machinery-go v0.0.0-20220913142420-e25cf57ea46d
 	github.com/openshift/client-go v0.0.0-20230120202327-72f107311084
-	github.com/openshift/library-go v0.0.0-20230427133628-add9892da47e
+	github.com/openshift/library-go v0.0.0-20230502125217-e45be8351afe
 	github.com/spf13/cobra v1.6.0
 	github.com/spf13/pflag v1.0.5
 	github.com/stretchr/testify v1.8.0

go.sum

@@ -418,8 +418,8 @@ github.com/openshift/build-machinery-go v0.0.0-20220913142420-e25cf57ea46d h1:RR
 github.com/openshift/build-machinery-go v0.0.0-20220913142420-e25cf57ea46d/go.mod h1:b1BuldmJlbA/xYtdZvKi+7j5YGB44qJUJDZ9zwiNCfE=
 github.com/openshift/client-go v0.0.0-20230120202327-72f107311084 h1:66uaqNwA+qYyQDwsMWUfjjau8ezmg1dzCqub13KZOcE=
 github.com/openshift/client-go v0.0.0-20230120202327-72f107311084/go.mod h1:M3h9m001PWac3eAudGG3isUud6yBjr5XpzLYLLTlHKo=
-github.com/openshift/library-go v0.0.0-20230427133628-add9892da47e h1:GFyfPd8IsGfsVANMM+WtNxmy0XBvvXF2Ie7Duzjbui0=
-github.com/openshift/library-go v0.0.0-20230427133628-add9892da47e/go.mod h1:JLv17uWyQvoK14yxp7h2vBJ8zz2xkWqanOv5TzuFkvY=
+github.com/openshift/library-go v0.0.0-20230502125217-e45be8351afe h1:vD0AgG+SQdktMtRKAfrGc91Ib5AJbGqnAfFFYzArAdY=
+github.com/openshift/library-go v0.0.0-20230502125217-e45be8351afe/go.mod h1:JLv17uWyQvoK14yxp7h2vBJ8zz2xkWqanOv5TzuFkvY=
 github.com/pborman/uuid v1.2.0/go.mod h1:X/NO0urCmaxf9VXbdlT7C2Yzkj2IKimNn4k+gtPdI/k=
 github.com/pelletier/go-toml v1.2.0/go.mod h1:5z9KED0ma1S8pY6P1sdut58dfprrGBbd/94hg7ilaic=
 github.com/peterbourgon/diskv v2.0.1+incompatible/go.mod h1:uqqh8zWWbv1HBMNONnaR/tNboyR3/BZd58JJSHlUSCU=

pkg/cmd/render/render.go

@@ -29,16 +29,16 @@ type renderOpts struct {
 	cloudProviderConfigOutputFile  string
 	// this file will be both input AND output
 	featureGateManifestFile string
-	payloadVersion          string
 }
 
 // NewRenderCommand creates a render command.
 func NewRenderCommand() *cobra.Command {
 	renderOpts := renderOpts{
-		generic:        *genericrenderoptions.NewGenericOptions(),
-		manifest:       *genericrenderoptions.NewManifestOptions("config", "openshift/origin-cluster-config-operator:latest"),
-		payloadVersion: "0.0.1-snapshot",
+		generic:  *genericrenderoptions.NewGenericOptions(),
+		manifest: *genericrenderoptions.NewManifestOptions("config", "openshift/origin-cluster-config-operator:latest"),
 	}
+	renderOpts.generic.PayloadVersion = "0.0.1-snapshot"
+
 	cmd := &cobra.Command{
 		Use:   "render",
 		Short: "Render kubernetes API server bootstrap manifests, secrets and configMaps",
@@ -76,7 +76,6 @@ func (r *renderOpts) AddFlags(fs *pflag.FlagSet) {
 	fs.StringVar(&r.cloudProviderConfigOutputFile, "cloud-provider-config-output-file", r.cloudProviderConfigOutputFile, "Output path for the generated cloud provider config file.")
 
 	fs.StringVar(&r.featureGateManifestFile, "featuregate-manifest", r.featureGateManifestFile, "Path for the FeatureGate.config.openshift.io that will be modified with completed status for use in other bootstrapping steps.")
-	fs.StringVar(&r.payloadVersion, "payload-version", r.payloadVersion, "Version that will eventually be placed into ClusterOperator.status.  This normally comes from the CVO set via env var: OPERATOR_IMAGE_VERSION.")
 
 }
 
@@ -139,7 +138,7 @@ func (r *renderOpts) Run() error {
 		}
 
 		featureGates := ReadFeatureGateV1OrDie(featureGateBytes)
-		currentDetails, err := featuregates.FeaturesGateDetailsFromFeatureSets(configv1.FeatureSets, featureGates, r.payloadVersion)
+		currentDetails, err := featuregates.FeaturesGateDetailsFromFeatureSets(configv1.FeatureSets, featureGates, r.generic.PayloadVersion)
 		if err != nil {
 			return err
 		}
@@ -164,22 +163,25 @@ func (r *renderOpts) Run() error {
 		return err
 	}
 
-	featureGateFiles := renderConfig.ListManifestOfType(configv1.GroupVersion.WithKind("FeatureGate"))
+	featureGateFiles, err := featureGateManifests(r.generic)
+	if err != nil {
+		return fmt.Errorf("problem with featuregate manifests: %w", err)
+	}
 	for _, featureGateFile := range featureGateFiles {
 		featureGatesObj, err := featureGateFile.GetDecodedObj()
 		if err != nil {
-			return err
+			return fmt.Errorf("error decoding FeatureGate: %w", err)
 		}
 		featureGates := featureGatesObj.(*configv1.FeatureGate)
-		currentDetails, err := featuregates.FeaturesGateDetailsFromFeatureSets(configv1.FeatureSets, featureGates, r.payloadVersion)
+		currentDetails, err := featuregates.FeaturesGateDetailsFromFeatureSets(configv1.FeatureSets, featureGates, r.generic.PayloadVersion)
 		if err != nil {
-			return err
+			return fmt.Errorf("error determining FeatureGates: %w", err)
 		}
 		featureGates.Status.FeatureGates = []configv1.FeatureGateDetails{*currentDetails}
 
 		featureGateOutBytes := WriteFeatureGateV1OrDie(featureGates)
 		if err := os.WriteFile(featureGateFile.OriginalFilename, []byte(featureGateOutBytes), 0644); err != nil {
-			return err
+			return fmt.Errorf("error writing FeatureGate manifest: %w", err)
 		}
 	}
 
@@ -199,3 +201,20 @@ func (r *renderOpts) Run() error {
 
 	return nil
 }
+
+func featureGateManifests(o genericrenderoptions.GenericOptions) (genericrenderoptions.RenderedManifests, error) {
+	if len(o.RenderedManifestInputFilenames) == 0 {
+		return nil, fmt.Errorf("cannot return FeatureGate without rendered manifests")
+	}
+
+	inputManifest, err := o.ReadInputManifests()
+	if err != nil {
+		return nil, fmt.Errorf("error reading input manifests: %w", err)
+	}
+	featureGates := inputManifest.ListManifestOfType(configv1.GroupVersion.WithKind("FeatureGate"))
+	if len(featureGates) == 0 {
+		return nil, fmt.Errorf("no FeatureGates found in manfest dir: %v", o.RenderedManifestInputFilenames)
+	}
+
+	return featureGates, nil
+}