Skip to content

Comments

Bump to latest openshift/api#314

Closed
patrickdillon wants to merge 1 commit intoopenshift:masterfrom
patrickdillon:bump-api
Closed

Bump to latest openshift/api#314
patrickdillon wants to merge 1 commit intoopenshift:masterfrom
patrickdillon:bump-api

Conversation

@patrickdillon
Copy link
Contributor

Pulls in changes for AWS private hosted zone feature

@openshift-ci openshift-ci bot requested review from soltysh and tkashem June 1, 2023 21:25
@deads2k
Copy link
Contributor

deads2k commented Jun 1, 2023

/lgtm
/approve

new fields are featuregated, fill in the form and get TRT to approve

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 1, 2023
@patrickdillon
Copy link
Contributor Author

Jun 01 22:00:52 ip-10-0-2-186 systemd[1]: Started Bootstrap a Kubernetes cluster.
Jun 01 22:00:56 ip-10-0-2-186 bootkube.sh[64669]: Rendering Kubernetes API server core manifests...
Jun 01 22:00:57 ip-10-0-2-186 bootkube.sh[66092]: F0601 22:00:57.971286       1 render.go:63] --rendered-manifest-files, are not consistent so results would be unpredictable depending on apply order: "0000_10_config-operator_01_dns-TechPreviewNoUpgrade.crd.yaml" and "0000_10_config-operator_01_dns.crd.yaml" both set CustomResourceDefinition.apiextensions.k8s.io/dnses.config.openshift.io in ns/, but have different values

When testing this

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 2, 2023

New changes are detected. LGTM label has been removed.

@openshift-ci openshift-ci bot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 2, 2023
@patrickdillon patrickdillon reopened this Jun 2, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 2, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 2, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 2, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@patrickdillon
Copy link
Contributor Author

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 4, 2023

@patrickdillon: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 6, 2023
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JoelSpeed
Copy link
Contributor

/close

Changes here were included in #317

@openshift-ci openshift-ci bot closed this Jun 6, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 6, 2023

@JoelSpeed: Closed this PR.

Details

In response to this:

/close

Changes here were included in #317

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants