Skip to content

Comments

CORS-2794: AWS Shared VPC API Bump [release-4.12]#344

Merged
openshift-merge-robot merged 2 commits intoopenshift:release-4.12from
patrickdillon:412-aws-shared-vpc
Sep 11, 2023
Merged

CORS-2794: AWS Shared VPC API Bump [release-4.12]#344
openshift-merge-robot merged 2 commits intoopenshift:release-4.12from
patrickdillon:412-aws-shared-vpc

Conversation

@patrickdillon
Copy link
Contributor

Manual backport of #337

@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 17, 2023

@patrickdillon: This pull request references CORS-2794 which is a valid jira issue.

Details

In response to this:

Manual backport of #337

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 17, 2023
@openshift-ci openshift-ci bot requested review from deads2k and tkashem August 17, 2023 18:53
@patrickdillon patrickdillon changed the title CORS-2794: AWS Shared VPC API Bump [release-4.13] CORS-2794: AWS Shared VPC API Bump [release-4.12] Aug 17, 2023
@patrickdillon
Copy link
Contributor Author

/retest

@patrickdillon
Copy link
Contributor Author

patrickdillon commented Aug 17, 2023

@JoelSpeed Any idea what is going on with this failure?

info: Included 187 images from 63 input operators into the release
error: unable to create a release: cluster-config-operator/stable.clusterresourcequota.testsuite.yaml: manifests must contain Kubernetes API objects with 'kind' and 'apiVersion' set: 
{"component":"entrypoint","error":"wrapped process failed: exit status 1","file":"k8s.io/test-infra/prow/entrypoint/run.go:84","func":"k8s.io/test-infra/prow/entrypoint.Options.internalRun","level":"error","msg":"Error executing test process","severity":"error","time":"2023-08-17T19:37:53Z"} 

The error is coming from oc adm release new:
https://github.com/openshift/oc/blob/705ef3fd163df4c2763fce653151b68e2ad3a8f0/pkg/cli/admin/release/new.go#L749-L754

But it's unclear to me why, for exampe, this is occurring here in the cluster-config-operator but not in the cluster-ingress-operator, which is vendoring the same API: https://github.com/openshift/cluster-ingress-operator/pull/971/files

Any ideas?

@patrickdillon
Copy link
Contributor Author

@wking pointed out that 4.13+ only copy crds in the Dockerfile. Added 8b4e647

Only copy CRDs to avoid build error:

manifests must contain Kubernetes API objects with 'kind' and 'apiVersion' set

Occurs if tests and other files are copied over when vendoring the API.
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 17, 2023

@patrickdillon: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@deads2k
Copy link
Contributor

deads2k commented Sep 7, 2023

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 7, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 7, 2023
@mrunalp mrunalp added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Sep 7, 2023
@mrunalp mrunalp added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Sep 7, 2023
@openshift-merge-robot openshift-merge-robot merged commit c589595 into openshift:release-4.12 Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants