Skip to content

[release-4.20] CORENET-6311: Skip running _stackmanager for libreswan 5.3+ #2872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
openshift-cherrypick-robot wants to merge 1 commit into
base: release-4.20
Choose a base branch
from
Open

[release-4.20] CORENET-6311: Skip running _stackmanager for libreswan 5.3+ #2872

openshift-cherrypick-robot wants to merge 1 commit into from
+10 −4

Conversation

@openshift-cherrypick-robot
Copy link

@openshift-cherrypick-robot openshift-cherrypick-robot commented Jan 9, 2026

This is an automated cherry-pick of #2787

/assign pperiyasamy

@pperiyasamy
Skip _stackmanager execution for libreswan 5.3+
f0682c2 
The _stackmanager binary was removed in libreswan 5.3 and is no
longer required for prerequisite checks. This commit conditionally
runs _stackmanager only when the binary is present on the system.

Signed-off-by: Periyasamy Palanisamy <pepalani@redhat.com>
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 9, 2026 •
edited by openshift-ci bot
Loading

@openshift-cherrypick-robot: Ignoring requests to cherry-pick non-bug issues: CORENET-6311

Details

In response to this:

This is an automated cherry-pick of #2787

/assign pperiyasamy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 9, 2026
Merged
@coderabbitai
Copy link

coderabbitai bot commented Jan 9, 2026 •
edited
Loading

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Review skipped — only excluded labels are configured. (1)
  • do-not-merge/work-in-progress

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Comment @coderabbitai help to get the list of available commands and usage tips.

@pperiyasamy
Copy link
Member

pperiyasamy commented Jan 13, 2026

/retest-required

@pperiyasamy
Copy link
Member

pperiyasamy commented Jan 13, 2026

/assign @igsilya @jcaamano @SachinNinganure @huiran0826

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 13, 2026 •
edited
Loading

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security f0682c2 link false /test security
ci/prow/4.20-upgrade-from-stable-4.19-e2e-azure-ovn-upgrade f0682c2 link false /test 4.20-upgrade-from-stable-4.19-e2e-azure-ovn-upgrade

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@pperiyasamy
Copy link
Member

pperiyasamy commented Jan 14, 2026

/retest-required

@jcaamano
Copy link
Contributor

jcaamano commented Jan 16, 2026

/lgtm
/approve
/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jan 16, 2026
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 16, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 16, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcaamano, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danwinship danwinship Awaiting requested review from danwinship

@pperiyasamy pperiyasamy Awaiting requested review from pperiyasamy

Assignees

@eurijon eurijon

@igsilya igsilya

@pperiyasamy pperiyasamy

@jcaamano jcaamano

@anuragthehatter anuragthehatter

@huiran0826 huiran0826

@asood-rh asood-rh

@imatza-rh imatza-rh

@SachinNinganure SachinNinganure

@barbora137 barbora137

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.