Skip to content

Comments

OCPBUGS-72407: add defaults for allowedRegistriesForImport that keep current behavior#652

Open
dusk125 wants to merge 1 commit intoopenshift:release-4.21from
dusk125:imagestreamimport-4.21
Open

OCPBUGS-72407: add defaults for allowedRegistriesForImport that keep current behavior#652
dusk125 wants to merge 1 commit intoopenshift:release-4.21from
dusk125:imagestreamimport-4.21

Conversation

@dusk125
Copy link

@dusk125 dusk125 commented Feb 20, 2026

This PR provides defaults that will keep the current behavior even with the change from allow-all to deny-all introduced here: openshift/openshift-apiserver#608.

This fix and the fix linked above will be backported to all supported releases to resolve OCPBUGS-72407.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 20, 2026
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 20, 2026
@openshift-ci-robot
Copy link

@dusk125: This pull request references Jira Issue OCPBUGS-72407, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected dependent Jira Issue OCPBUGS-72408 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This PR provides defaults that will keep the current behavior even with the change from allow-all to deny-all introduced here: openshift/openshift-apiserver#607

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from dgrisonnet February 20, 2026 20:45
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 20, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dusk125
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot requested a review from tkashem February 20, 2026 20:45
@dusk125 dusk125 changed the title WIP: OCPBUGS-72407: add defaults for allowedRegistriesForImport that keep current behavior OCPBUGS-72407: add defaults for allowedRegistriesForImport that keep current behavior Feb 20, 2026
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 20, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 20, 2026

@dusk125: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants