[th/mrvl-vsp-dp-rework] Marvell VSP: Add configurable MAC learning for OVS data plane#611
Conversation
Add isMacLearning parameter to control bridge switching behavior. When true, configures highest priority NORMAL flow for MAC-based learning. When false, allows traffic routing through network functions. Signed-off-by: Alkama Hasan <alkamah@marvell.com> Signed-off-by: Thomas Haller <thaller@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: thom311 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@thom311: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
|
/verified bypass |
openshift-ci-robot
added
the
verified
|
@wizhaoredhat: The DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
4 participants
Add isMacLearning parameter to control bridge switching behavior. When true, configures highest priority NORMAL flow for MAC-based learning. When false, allows traffic routing through network functions.
This takes the first patch of #562 so we can merge that part.
It works fine, but note that in our Marvell CI system (Jenkins job 99_E2E_Marvell_DPU_Deploy), we skip NF tests via
export SKIP_NF_TESTING=true, so we don't actually test this change in that CI system.The problem is, that the related tests under
e2e-test/e2e-test.gohave a hard-codedEXTERNAL_CLIENT_DEV=eno12409, which is not correct on the system with our Marvell CI (there the corresponding interface is calledeno2).We should fix that separately (https://issues.redhat.com/browse/MDC-132). On #562 there is also a patch
e2e-test: Removed skipNetworkFunctionTesting Option from e2e-test to test Marvell VSP Default DP With NF.which would dropSKIP_NF_TESTING=true. But we cannot do that without first addressing the issue of hard-codedEXTERNAL_CLIENT_DEV=eno12409. A potential solution could be #579, or something else entirely. That patch should be picked up later.But the problem with the CI should not block this patch.
CC @alkama-hasan