oape: controller implementation from EP #1834#109
Open
swghosh wants to merge 3 commits intoopenshift:ai-staging-release-1.1from
Open
oape: controller implementation from EP #1834#109swghosh wants to merge 3 commits intoopenshift:ai-staging-release-1.1from
swghosh wants to merge 3 commits intoopenshift:ai-staging-release-1.1from
Conversation
Adds NetworkPolicy API type improvements and comprehensive integration tests for the ExternalSecretsConfig networkPolicies field from EP #1834. Changes: - Fix godoc comments on ComponentName constants (trailing periods) - Add DNS subdomain validation pattern for NetworkPolicy name field - Improve Egress field documentation for clarity - Fix Egress JSON tag (remove omitempty for Required field) - Fix listType marker spacing - Add 15 new integration test cases covering: - NetworkPolicy creation for CoreController and BitwardenSDKServer - Multiple networkPolicies in a single config - Allow-all egress and deny-all egress configurations - DNS name validation (uppercase, underscores, leading/trailing hyphens) - Empty networkPolicies list handling - Name length validation - Invalid componentName validation - NetworkPolicy addition after creation (onUpdate) - Immutability of name and componentName fields (onUpdate) - Regenerated CRD manifests with updated validation Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Adds stale custom NetworkPolicy cleanup logic and RBAC improvements for the NetworkPolicy feature from EP #1834. Changes: - Add RBAC delete verb for networkpolicies to enable cleanup - Add custom network policy label for lifecycle management - Implement deleteStaleCustomNetworkPolicies() to remove NetworkPolicies that are no longer referenced in ExternalSecretsConfig spec - Add comprehensive unit tests for stale policy cleanup (no stale, single stale, all stale, list error, delete error) - Update buildNetworkPolicyFromConfig to apply custom label - Regenerated RBAC role.yaml Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord. Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: swghosh The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
… pods The DNS allow policy was only covering external-secrets and bitwarden-sdk-server pods, leaving webhook and cert-controller pods without DNS resolution capability. This would prevent those pods from resolving the API server hostname, effectively breaking their API server connectivity. Add external-secrets-webhook and external-secrets-cert-controller to the DNS policy podSelector matchExpressions to ensure all operand components can resolve DNS names. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
deleteverb fornetworkpoliciesresource to enable cleanupoperator.openshift.io/custom-network-policylabel to distinguish custom from static policiesStacks on top of #108 (API types + tests)
Auto-generated controller/reconciler code from openshift/enhancements#1834
Test plan
make buildpassesmake testpasses (67/67 API tests, all unit tests pass)external_secretscontroller: 67.9%🤖 Generated with Claude Code