oape: e2e tests from EP #1834#110
Open
swghosh wants to merge 2 commits intoopenshift:ai-staging-release-1.1from
Open
oape: e2e tests from EP #1834#110swghosh wants to merge 2 commits intoopenshift:ai-staging-release-1.1from
swghosh wants to merge 2 commits intoopenshift:ai-staging-release-1.1from
Conversation
Adds NetworkPolicy API type improvements and comprehensive integration tests for the ExternalSecretsConfig networkPolicies field from EP #1834. Changes: - Fix godoc comments on ComponentName constants (trailing periods) - Add DNS subdomain validation pattern for NetworkPolicy name field - Improve Egress field documentation for clarity - Fix Egress JSON tag (remove omitempty for Required field) - Fix listType marker spacing - Add 15 new integration test cases covering: - NetworkPolicy creation for CoreController and BitwardenSDKServer - Multiple networkPolicies in a single config - Allow-all egress and deny-all egress configurations - DNS name validation (uppercase, underscores, leading/trailing hyphens) - Empty networkPolicies list handling - Name length validation - Invalid componentName validation - NetworkPolicy addition after creation (onUpdate) - Immutability of name and componentName fields (onUpdate) - Regenerated CRD manifests with updated validation Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: swghosh The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Generated e2e test artifacts for NetworkPolicy feature: - test-cases.md: 10 test scenarios covering custom NP lifecycle, validation, and static policies - execution-steps.md: Step-by-step oc commands for manual execution - e2e_test.go: Ginkgo e2e test code matching existing repo patterns - e2e-suggestions.md: Prioritized test recommendations Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
swghosh
force-pushed
the
oape/e2e-1834
branch
from
7803bef to
e99f593
Compare
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacks on top of #108 (API types + tests)
Auto-generated e2e test artifacts from openshift/enhancements#1834
Test plan
make buildpasses//go:build e2e)🤖 Generated with Claude Code