Skip to content

Comments

CNTRLPLANE-244: Enable initial GitHub Action jobs#5706

Merged
sjenning merged 2 commits intoopenshift:mainfrom
bryan-cox:github-actions
Feb 28, 2025
Merged

CNTRLPLANE-244: Enable initial GitHub Action jobs#5706
sjenning merged 2 commits intoopenshift:mainfrom
bryan-cox:github-actions

Conversation

@bryan-cox
Copy link
Member

@bryan-cox bryan-cox commented Feb 25, 2025 •
edited
Loading

What this PR does / why we need it:
This PR enables an initial set of GitHub Action jobs including: codespell, golangci-lint, verify, and unit testing

Which issue(s) this PR fixes:
A part of CNTRLPLANE-244

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 25, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-cox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 25, 2025
@bryan-cox bryan-cox force-pushed the github-actions branch 16 times, most recently from 245e1db to f2cb76d Compare February 25, 2025 22:07
@bryan-cox bryan-cox changed the title Add codespell to GitHub Actions Enable initial GitHub Action jobs Feb 25, 2025
@bryan-cox bryan-cox force-pushed the github-actions branch 2 times, most recently from 0fe5677 to 6e6592f Compare February 25, 2025 22:08
@bryan-cox
Copy link
Member Author

bryan-cox commented Feb 25, 2025

/area ci-tooling

@openshift-ci openshift-ci bot added area/ci-tooling Indicates the PR includes changes for CI or tooling and removed do-not-merge/needs-area labels Feb 25, 2025
@openshift-ci openshift-ci bot added the area/documentation Indicates the PR includes changes for documentation label Feb 26, 2025
@bryan-cox bryan-cox changed the title Enable initial GitHub Action jobs CNTRLPLANE-244: Enable initial GitHub Action jobs Feb 26, 2025
@bryan-cox bryan-cox force-pushed the github-actions branch 4 times, most recently from fe5208c to 4b2440b Compare February 26, 2025 20:08
sjenning
sjenning reviewed Feb 26, 2025
View reviewed changes
@sjenning
Copy link
Contributor

sjenning commented Feb 26, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 26, 2025
@sjenning
Copy link
Contributor

sjenning commented Feb 26, 2025

/override ci/prow/e2e-aks
/override ci/prow/e2e-aws
/override ci/prow/e2e-aws-upgrade-hypershift-operator
/override ci/prow/e2e-kubevirt-aws-ovn-reduced
/override ci/prow/okd-scos-e2e-aws-ovn

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 26, 2025

@sjenning: Overrode contexts on behalf of sjenning: ci/prow/e2e-aks, ci/prow/e2e-aws, ci/prow/e2e-aws-upgrade-hypershift-operator, ci/prow/e2e-kubevirt-aws-ovn-reduced, ci/prow/okd-scos-e2e-aws-ovn

Details

In response to this:

/override ci/prow/e2e-aks
/override ci/prow/e2e-aws
/override ci/prow/e2e-aws-upgrade-hypershift-operator
/override ci/prow/e2e-kubevirt-aws-ovn-reduced
/override ci/prow/okd-scos-e2e-aws-ovn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 27, 2025

/retest-required

Remaining retests: 0 against base HEAD e73cc84 and 2 for PR HEAD 42fd69e in total

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 27, 2025

/retest-required

Remaining retests: 0 against base HEAD a997c61 and 1 for PR HEAD 42fd69e in total

@bryan-cox
Copy link
Member Author

bryan-cox commented Feb 27, 2025

/retest-required

@bryan-cox
Copy link
Member Author

bryan-cox commented Feb 27, 2025

/retest

@bryan-cox
Copy link
Member Author

bryan-cox commented Feb 27, 2025

/test e2e-aws

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 27, 2025

/retest-required

Remaining retests: 0 against base HEAD 7fe494a and 2 for PR HEAD 42fd69e in total

@bryan-cox
Copy link
Member Author

bryan-cox commented Feb 28, 2025

/retest

1 similar comment
@bryan-cox
Copy link
Member Author

bryan-cox commented Feb 28, 2025

/retest

@bryan-cox
Enable initial GitHub Action jobs
f3aa761 
This commit enables an initial set of GitHub Action jobs including:
codespell, golangci-lint, verify, and unit testing

Signed-off-by: Bryan Cox <brcox@redhat.com>
@bryan-cox
Fix spelling mistake
0d00b8c 
Signed-off-by: Bryan Cox <brcox@redhat.com>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 28, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 28, 2025

New changes are detected. LGTM label has been removed.

@bryan-cox
Copy link
Member Author

bryan-cox commented Feb 28, 2025

/test verify

@bryan-cox
Copy link
Member Author

bryan-cox commented Feb 28, 2025

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 28, 2025

@bryan-cox: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aks 0d00b8c link true /test e2e-aks
ci/prow/verify 0d00b8c link true /test verify

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@sjenning sjenning merged commit f034429 into openshift:main Feb 28, 2025
14 of 18 checks passed
@bryan-cox
Copy link
Member Author

bryan-cox commented Feb 28, 2025

/retest

@openshift-bot
Copy link

openshift-bot commented Mar 1, 2025

[ART PR BUILD NOTIFIER]

Distgit: hypershift
This PR has been included in build ose-hypershift-container-v4.19.0-202503010038.p0.gf034429.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sjenning sjenning sjenning left review comments

@hasueki hasueki Awaiting requested review from hasueki

@isco-rodriguez isco-rodriguez Awaiting requested review from isco-rodriguez

Assignees

@sjenning sjenning

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ci-tooling Indicates the PR includes changes for CI or tooling area/documentation Indicates the PR includes changes for documentation jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bryan-cox @openshift-ci-robot @sjenning @openshift-bot