Skip to content

Comments

OCPBUGS-65582: set Progressing condition on cluster update#1207

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
opokornyy:OCPBUGS-65582-progressing-condition
Jan 19, 2026
Merged

OCPBUGS-65582: set Progressing condition on cluster update#1207
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
opokornyy:OCPBUGS-65582-progressing-condition

Conversation

@opokornyy
Copy link
Contributor

This PR implements functionality to set the Progressing condition of the insights clusteroperator to True when the OpenShift version updates its minor or major version, while ignoring patch version updates.

Categories

  • Bugfix
  • Data Enhancement
  • Feature
  • Backporting
  • Others (CI, Infrastructure, Documentation)

Sample Archive

  • None

Documentation

  • None

Unit Tests

  • pkg/controller/status/controller_test.go

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

  • None

Breaking Changes

No

References

OCPBUGS-65582

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 9, 2026
@openshift-ci-robot
Copy link
Contributor

@opokornyy: This pull request references Jira Issue OCPBUGS-65582, which is invalid:

  • expected the bug to target the "4.22.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This PR implements functionality to set the Progressing condition of the insights clusteroperator to True when the OpenShift version updates its minor or major version, while ignoring patch version updates.

Categories

  • Bugfix
  • Data Enhancement
  • Feature
  • Backporting
  • Others (CI, Infrastructure, Documentation)

Sample Archive

  • None

Documentation

  • None

Unit Tests

  • pkg/controller/status/controller_test.go

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

  • None

Breaking Changes

No

References

OCPBUGS-65582

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from BaiyangZhou and ncaak January 9, 2026 10:02
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 9, 2026
@BaiyangZhou
Copy link

/test e2e-gcp-ovn-techpreview

@hongkailiu
Copy link
Member

/payload-job periodic-ci-openshift-release-master-ci-4.21-upgrade-from-stable-4.20-e2e-gcp-ovn-rt-upgrade

@openshift-ci
Copy link

openshift-ci bot commented Jan 13, 2026

@hongkailiu: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.21-upgrade-from-stable-4.20-e2e-gcp-ovn-rt-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/b5427640-f05a-11f0-8591-ad49f670dd46-0

@opokornyy opokornyy force-pushed the OCPBUGS-65582-progressing-condition branch from b7d02cf to 481aa64 Compare January 13, 2026 15:11
This commit implements functionality to set the
Progressing condition of the insights
clusteroperator to True when the OpenShift version
updates its minor or major version, while ignoring
patch version updates.

Signed-off-by: Ondrej Pokorny <opokorny@redhat.com>
@opokornyy opokornyy force-pushed the OCPBUGS-65582-progressing-condition branch from 481aa64 to bb4fdc7 Compare January 13, 2026 15:17
@opokornyy
Copy link
Contributor Author

/retest

@BaiyangZhou
Copy link

/test insights-operator-e2e-tests

2 similar comments
@BaiyangZhou
Copy link

/test insights-operator-e2e-tests

@BaiyangZhou
Copy link

/test insights-operator-e2e-tests

@openshift-ci
Copy link

openshift-ci bot commented Jan 16, 2026

@opokornyy: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ncaak
Copy link
Contributor

ncaak commented Jan 19, 2026

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@ncaak: This pull request references Jira Issue OCPBUGS-65582, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ncaak
Copy link
Contributor

ncaak commented Jan 19, 2026

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 19, 2026
@openshift-ci-robot
Copy link
Contributor

@ncaak: This pull request references Jira Issue OCPBUGS-65582, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.22.0) matches configured target version for branch (4.22.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sunzhaohua2

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from sunzhaohua2 January 19, 2026 11:41
@ncaak
Copy link
Contributor

ncaak commented Jan 19, 2026

/verified later @BaiyangZhou

@openshift-ci-robot openshift-ci-robot added verified-later verified Signifies that the PR passed pre-merge verification criteria labels Jan 19, 2026
@openshift-ci-robot
Copy link
Contributor

@ncaak: This PR has been marked to be verified later by @BaiyangZhou.

Details

In response to this:

/verified later @BaiyangZhou

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

@ncaak ncaak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 19, 2026
@openshift-ci
Copy link

openshift-ci bot commented Jan 19, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ncaak, opokornyy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 073e371 into openshift:master Jan 19, 2026
12 checks passed
@openshift-ci-robot
Copy link
Contributor

@opokornyy: Jira Issue OCPBUGS-65582: All pull requests linked via external trackers have merged:

This pull request has the verified-later tag and will need to be manually moved to VERIFIED after testing. Jira Issue OCPBUGS-65582 has been moved to the MODIFIED state.

Details

In response to this:

This PR implements functionality to set the Progressing condition of the insights clusteroperator to True when the OpenShift version updates its minor or major version, while ignoring patch version updates.

Categories

  • Bugfix
  • Data Enhancement
  • Feature
  • Backporting
  • Others (CI, Infrastructure, Documentation)

Sample Archive

  • None

Documentation

  • None

Unit Tests

  • pkg/controller/status/controller_test.go

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

  • None

Breaking Changes

No

References

OCPBUGS-65582

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.22.0-0.nightly-2026-01-21-055002

@opokornyy
Copy link
Contributor Author

/cherry-pick release-4.21

@openshift-cherrypick-robot

@opokornyy: new pull request created: #1217

Details

In response to this:

/cherry-pick release-4.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@opokornyy
Copy link
Contributor Author

/cherry-pick release-4.20

@openshift-cherrypick-robot

@opokornyy: new pull request created: #1219

Details

In response to this:

/cherry-pick release-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria verified-later

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants