CCXDEV-15561: Improve test coverage 4#1226
CCXDEV-15561: Improve test coverage 4#1226katushiik11 wants to merge 5 commits intoopenshift:masterfrom
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@katushiik11: This pull request references CCXDEV-15561 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
approved
|
/retest |
2 similar comments
|
/retest |
|
/retest |
| expected: false, | ||
| }, | ||
| { | ||
| name: "should process - exactly at period boundary", |
There was a problem hiding this comment.
The third and fourth test cases looks like duplicates, imo we could drop them
|
@katushiik11: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
ncaak
left a comment
ncaak
left a comment
There was a problem hiding this comment.
Overall, it looks good.
I have a few minor concerns about some field names, such as "now" and "expected," which could be more specific. However, the tests are readable, so I won't push for a refactor.
I approve these changes, but I'll let @opokornyy give final approval and the "lgtm" label.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: katushiik11, ncaak The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
5 participants
This PR implements tests to improve test coverage in directories, utils, utils/check, controller/periodic & cmd/obfuscate-archive.
Categories
Sample Archive
Documentation
Unit Tests
pkg/utils/count_lines_test.gopkg/utils/gatherers_test.gopkg/utils/line_limit_reader_test.gopkg/utils/check/has_container_in_crashloop_test.gopkg/utils/check/is_healthy_pod_test.gopkg/controller/periodic/datagather_informer_test.gocmd/obfuscate-archive/main_test.goPrivacy
Yes. There are no sensitive data in the newly collected information.
Changelog
No
Breaking Changes
No
References
https://issues.redhat.com/browse/CCXDEV-15561