[release-4.19] OCPBUGS-76962: Extends the time for the extractor liveness probe

[jmesnil]

Categories

• Backporting

Before:

• crictl info was timing out after 2 seconds
• the command was executed every 10 seconds
• 2 failures were making the container unhealthy
• => 10 seconds of unavailability was making the pod crash

This was too constraining as there are occasions where crictl can be unavailable for a longer period of time (eg when the TLS CA bundle requires to restart some pods)

Now:

• crictl info is timing out after 10 seconds
• the command is executed every 30 seconds
• 3 failures (default) are making the container unhealthy
• => 1m30s of unaivailability is making the pod crash

Note: The liveness probe is used instead of the readiness probe as the container MUST crash if the crictl connection has been changed (eg following a TLS CA bundle update) and at this point, the pod must be recreated to be able to connect to cri-o socket with an updated TLS certificate.

This fixes https://issues.redhat.com/browse/OCPBUGS-76962
Upstream issue is https://issues.redhat.com/browse/OCPBUGS-66996

[openshift-ci-robot]

@jmesnil: This pull request references Jira Issue OCPBUGS-66996, which is invalid:

• expected the bug to target either version "4.19." or "openshift-4.19.", but it targets "4.22.0" instead
• expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead
• release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
• expected Jira Issue OCPBUGS-66996 to depend on a bug targeting a version in 4.20.0, 4.20.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Categories

• Backporting

Before:

• crictl info was timing out after 2 seconds
• the command was executed every 10 seconds
• 2 failures were making the container unhealthy
• => 10 seconds of unavailability was making the pod crash

This was too constraining as there are occasions where crictl can be unavailable for a longer period of time (eg when the TLS CA bundle requires to restart some pods)

Now:

• crictl info is timing out after 10 seconds
• the command is executed every 30 seconds
• 3 failures (default) are making the container unhealthy
• => 1m30s of unaivailability is making the pod crash

Note: The liveness probe is used instead of the readiness probe as the container MUST crash if the crictl connection has been changed (eg following a TLS CA bundle update) and at this point, the pod must be recreated to be able to connect to cri-o socket with an updated TLS certificate.

This fixes https://issues.redhat.com/browse/OCPBUGS-66996

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[jmesnil]

Upstream is #1198

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jmesnil
Once this PR has been reviewed and has the lgtm label, please assign baiyangzhou for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jmesnil]

/jira refresh

[openshift-ci-robot]

@jmesnil: This pull request references Jira Issue OCPBUGS-66996, which is invalid:

• expected the bug to target either version "4.19." or "openshift-4.19.", but it targets "4.22.0" instead
• expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead
• release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
• expected Jira Issue OCPBUGS-66996 to depend on a bug targeting a version in 4.20.0, 4.20.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@jmesnil: This pull request references Jira Issue OCPBUGS-76962, which is invalid:

• release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
• expected dependent Jira Issue OCPBUGS-76961 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is New instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Categories

• Backporting

Before:

• crictl info was timing out after 2 seconds
• the command was executed every 10 seconds
• 2 failures were making the container unhealthy
• => 10 seconds of unavailability was making the pod crash

This was too constraining as there are occasions where crictl can be unavailable for a longer period of time (eg when the TLS CA bundle requires to restart some pods)

Now:

• crictl info is timing out after 10 seconds
• the command is executed every 30 seconds
• 3 failures (default) are making the container unhealthy
• => 1m30s of unaivailability is making the pod crash

Note: The liveness probe is used instead of the readiness probe as the container MUST crash if the crictl connection has been changed (eg following a TLS CA bundle update) and at this point, the pod must be recreated to be able to connect to cri-o socket with an updated TLS certificate.

This fixes https://issues.redhat.com/browse/OCPBUGS-76962
Upstream issue is https://issues.redhat.com/browse/OCPBUGS-66996

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[jmesnil]

/jira refresh

[openshift-ci-robot]

@jmesnil: This pull request references Jira Issue OCPBUGS-76962, which is invalid:

• release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
• expected dependent Jira Issue OCPBUGS-76961 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is New instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@jmesnil: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/okd-scos-images	4da1836	link	true	/test okd-scos-images

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.