OCPBUGS-74631: Add validation to reject userProvisionedDNS on Azure Stack Hub

[jinyunma]

Custom DNS (userProvisionedDNS) is not supported on Azure Stack Hub.
This change adds validation to prevent users from setting userProvisionedDNS on Azure Stack Hub.

[openshift-ci-robot]

@jinyunma: This pull request references Jira Issue OCPBUGS-74631, which is invalid:

• expected the bug to target the "4.22.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Custom DNS (userProvisionedDNS) is not supported on Azure Stack Hub.
This change adds validation to prevent users from setting userProvisionedDNS on Azure Stack Hub.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[jinyunma]

/jira refresh

[openshift-ci-robot]

@jinyunma: This pull request references Jira Issue OCPBUGS-74631, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.22.0) matches configured target version for branch (4.22.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jinyunma

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: jinyunma.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

@jinyunma: This pull request references Jira Issue OCPBUGS-74631, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.22.0) matches configured target version for branch (4.22.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jinyunma

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[jinyunma]

Tested locally, installer exited with error message when creating manifests with userProvisionedDNS enabled on Azure Stack Hub.

$ ./openshift-install create manifests --dir ipi/
INFO ipFamily is not specified in install-config; defaulting to "IPv4" 
WARNING Release Image Architecture not detected. Release Image Architecture is unknown 
ERROR failed to fetch Master Machines: failed to load asset "Install Config": failed to create install config: invalid "install-config.yaml" file: platform.azure.userProvisionedDNS: Invalid value: "Enabled": userProvisionedDNS is not supported on Azure Stack Hub

[openshift-ci]

@jinyunma: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-azure-ovn-shared-vpc	de51668	link	false	/test e2e-azure-ovn-shared-vpc
ci/prow/e2e-azurestack	de51668	link	false	/test e2e-azurestack

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[patrickdillon]

/lgtm
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• pkg/types/azure/OWNERS [patrickdillon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jinyunma]

/verified by jima

[openshift-ci-robot]

@jinyunma: This PR has been marked as verified by jima.

Details

In response to this:

/verified by jima

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 5314736 and 2 for PR HEAD de51668 in total

[openshift-ci-robot]

@jinyunma: Jira Issue Verification Checks: Jira Issue OCPBUGS-74631
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-74631 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

Custom DNS (userProvisionedDNS) is not supported on Azure Stack Hub.
This change adds validation to prevent users from setting userProvisionedDNS on Azure Stack Hub.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.