-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Use Konnectivity for pod network access from bootstrap KAS #10280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
patrickdillon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
|
|
||
| // Clean up bootstrap-only cluster resources (e.g., Konnectivity agent DaemonSet) | ||
| // This runs after infrastructure is destroyed, so failures are warnings only. | ||
| if err := deleteBootstrapClusterResources(ctx, dir); err != nil { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
konnectivity cleanup/delete should be moved to the end of the bootkube script. The cleanup should be part of bootstrapping, so that bootstrapping is not done until konnectivity is cleaned up--rather than cleanup being part of bootstrap destroy.
At present, at least in most cases (I'm not aware of any exceptions), we can successfully provision clusters without the installer connecting to the API LB.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As long as we don't dismantle konnectivity until the after the bootstrap KAS is gone this is fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Incidentally, I also wondered if it might be cleaner to put all these resources in an openshift-bootstrap namespace. Then we can just delete the namespace on teardown instead of having to keep track of multiple objects.
Also, if you think there's any mileage in moving the agent definition to an asset, we could have bootstrap.sh just write its IP to a configmap instead of creating the daemonset.
|
/test ? |
|
/test e2e-aws-default-config e2e-aws-ovn-techpreview |
|
@mdbooth: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Enables kube-apiserver running on the bootstrap node to access the pod network,
specifically to enable access to webhooks running in the cluster.
Changes:
outbound cluster traffic
cluster node
Slack thread: https://redhat-internal.slack.com/archives/C68TNFWA2/p1769796074939399?thread_ts=1769601349.942229&cid=C68TNFWA2
tl;dr This is a PoC, but it works (on AWS) in my manual testing.